Extended instrument zapping #187
Conversation
|
i'm thinking maybe this should just be a little "-" button under the instrument list, as i'm not sure otherwise people unfamiliar with the feature would discover it exists, as currently zap->instruments just deletes all of them |
arm9/source/main.cpp
Outdated
| { | ||
| deleteMessageBox(); | ||
| mb = new MessageBox(&sub_vram, "which instruments", 4, "selected", zapCurrentInstrument, "unused", zapUnusedInstruments, | ||
| " all ", zapInstruments, "cancel", |
There was a problem hiding this comment.
Can we have an additional message box if you choose "all", just to confirm that's really what you want to do, in case someone mis-touches?
There was a problem hiding this comment.
Sure, although I was also considering moving the individual instrument deletion to a "-" button under the instruments list to make it more obvious, up to you though
There was a problem hiding this comment.
We'd need to move the patterns and song zappers somewhere too, then, I think. But I am not attached to "zap!".
There was a problem hiding this comment.
ah, fair enough. i suppose i am not either although it would be nice to leave it in there as i presume it is a reference to the "zap!" of FT2 which would be a shame to remove (*imo). For now I'll just add the confirmation step as you said (should the same confirmation also apply to zapping patterns/song too?)
There was a problem hiding this comment.
(btw, by the initial comment I meant keep the current zap menu, then separately have a tiny "-" under the instruments list - ie zapping or clearing all insts/song/etc would be different ux wise to just managing individual instrument deletion
|
Thank you! |
2 participants
closes #179 #136 #54
This is what the dialogue looks like - it is an extra set of options on top of the zap -> instruments menu
Also, requires NitrousTracker/libntxm#21, because of a bug in Song.cpp that causes massive delays the more null instruments there are between two non-null ones