python3Packages.process-tests: optional ignore_case param to wait_for_strings #324348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: python
NixOSInfra
added
the
12.first-time contribution
erictapen
changed the title
erictapen
reviewed
Jul 3, 2024
erictapen
approved these changes
Jul 3, 2024
Member
erictapen
left a comment
erictapen
left a comment
There was a problem hiding this comment.
Looks great! Could you squash, so there is only one commit to merge?
…_strings PR: ionelmc/python-process-tests#7 Co-authored-by: Kerstin <kerstin@erictapen.name>
summersamara
force-pushed
the
python-process-tests-add-patch
branch
from
693d51e to
e5d1376
Compare
Member
|
Thanks! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is required to fix the tests in
python3Packages.python-redis-lockfetch patch from the following PR
ionelmc/python-process-tests#7
The patch adds an option to ignore strings case in
wait_for_stringsfunctionThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.