-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
Remove html5lib from check phase dependencies #463002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed 'html5lib' from the check phase dependencies.
|
@SuperSandro2000 I saw you are also interested in Sphinx builds in #443797 I honestly don't care too much about who commits this to |
|
I suggest to prefix the title of this PR with |
It is really not, just target master for any PR. If it triggers to many rebuilds it goes to staging and then there are some extras for 25.05 which we don't have here.
Yeah, I think there is some work to get this synced but I am not watching that closely. To get normally my attention you need to target PRs to master and then the CI requests my review on them if I am maintaining the packages. |
| # check phase | ||
| defusedxml, | ||
| filelock, | ||
| html5lib, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we only will receive an error because the package is still used below.
|
Also the PR you linked was primarily about pypy3Packages. |
|
python314Packages is going to be recursed in #462746, so until that is merged, it will not receive much love. Also from the other PR this will trigger 5000+ rebuilds. Hence I am also closing this PR. |
|
html5lib compatbility with 3.14 is also already fixed in 9c0fcb5 |
|
@SuperSandro2000 Is this mergeable if I fix the other occurrence of Even though |
|
If sphinx does not need it anymore, we should remove it but that PR should be targeted towards staging and it should be tested at least with sphinx. |
Removed 'html5lib' from the check phase dependencies.
As of sphinx-doc/sphinx#12173 this is no longer necessary for the check phase.
This is important as this package is not compatible with Python 3.14 because of html5lib/html5lib-python#589 and due to lack of releases in recent times likely won't be very soon.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.