Skip to content

Conversation

@DanielNoord
Copy link

Removed 'html5lib' from the check phase dependencies.

As of sphinx-doc/sphinx#12173 this is no longer necessary for the check phase.

This is important as this package is not compatible with Python 3.14 because of html5lib/html5lib-python#589 and due to lack of releases in recent times likely won't be very soon.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Removed 'html5lib' from the check phase dependencies.
@DanielNoord
Copy link
Author

@SuperSandro2000 I saw you are also interested in Sphinx builds in #443797

I honestly don't care too much about who commits this to main and the whole PR and CI process in this repository is a bit daunting, but since this breaks builds of Sphinx on Python 3.14 it would be nice to merge somewhat soonish.
How can I get this the attention I think it deserves from lib.team.sphinx? It doesn't seem to be a team I can tag on Github.

@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Nov 18, 2025
@aleclearmind
Copy link

I suggest to prefix the title of this PR with python314Packages.sphinx: .

@SuperSandro2000
Copy link
Member

I honestly don't care too much about who commits this to main and the whole PR and CI process in this repository is a bit daunting

It is really not, just target master for any PR. If it triggers to many rebuilds it goes to staging and then there are some extras for 25.05 which we don't have here.

How can I get this the attention I think it deserves from lib.team.sphinx? It doesn't seem to be a team I can tag on Github.

Yeah, I think there is some work to get this synced but I am not watching that closely.

To get normally my attention you need to target PRs to master and then the CI requests my review on them if I am maintaining the packages.

# check phase
defusedxml,
filelock,
html5lib,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we only will receive an error because the package is still used below.

@SuperSandro2000
Copy link
Member

Also the PR you linked was primarily about pypy3Packages.

@SuperSandro2000
Copy link
Member

python314Packages is going to be recursed in #462746, so until that is merged, it will not receive much love.

Also from the other PR this will trigger 5000+ rebuilds.

Hence I am also closing this PR.

@SuperSandro2000
Copy link
Member

html5lib compatbility with 3.14 is also already fixed in 9c0fcb5

@DanielNoord
Copy link
Author

@SuperSandro2000 Is this mergeable if I fix the other occurrence of html5lib (for some reason Github didn't show that when I ctrl + F'd).

Even though 3.14 compatibility is fixed Sphinx doesn't need this input anymore (as shown by the PR I linked) so it would be good to clean this up anyway.

@SuperSandro2000
Copy link
Member

If sphinx does not need it anymore, we should remove it but that PR should be targeted towards staging and it should be tested at least with sphinx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants