Skip to content

coolreader: fix build & 3.2.57 -> 3.2.58 #466281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Jan 4, 2026
Merged

coolreader: fix build & 3.2.57 -> 3.2.58 #466281

SuperSandro2000 merged 1 commit into from
Jan 4, 2026

Conversation

@Jappie3
Copy link
Contributor

@Jappie3 Jappie3 commented Nov 29, 2025 •
edited
Loading

see #445447 for cmake4

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 29, 2025
Sigmanificient
Sigmanificient previously requested changes Nov 29, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 29, 2025
@Sigmanificient Sigmanificient mentioned this pull request Jan 3, 2026
Open
@Jappie3 Jappie3 mentioned this pull request Jan 3, 2026
Open
@Sigmanificient
Copy link
Member

Sigmanificient commented Jan 3, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 466281
Commit: 073f62626be25d6a1911badbca62c9ddccdafbf1 (subsequent changes)
Merge: fd43623440b508e7a8a13620a9e6af3eb669d284

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/20684270289

x86_64-linux

✅ 1 package built:
  • coolreader

aarch64-linux

✅ 1 package built:
  • coolreader

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Jan 4, 2026
Merged via the queue into NixOS:master with commit d410f14 Jan 4, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jappie3 @Sigmanificient @SuperSandro2000