Skip to content

Conversation

@purcebr
Copy link

@purcebr purcebr commented Jul 24, 2017

…s files.

What does this PR cover?

Allowing an assets.json file to override the assets portion of data.json

How can this be tested?

Add an assets.json file with the format:

{ "css": [], "js":[] }

Screenshots / Screencast

What gif best describes how you feel about this work?

👍


Reviewers

Review 1

  • 👍

Review 2 (optional)

  • 👍

By adding a +1 you are confirming you have...

  • Witnessed the work behaving as expected (this could be on the author's machine or screencast).
  • Checked for coding anti-patterns.

I added a minified version in, not sure if that's something you before a release? Let me know if you need any thing else from me. I can merge it into the 2.0 branch, too - I remember you mentioned that we'd need to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant