Skip to content

Conversation

@giothevanni
Copy link

@giothevanni giothevanni commented Mar 28, 2018

What does this PR cover?

Fixing #129 and updating 2 major releases of webpack in the process (from 2 to 4)

  • Changed the loading of Vue from commonJS to ES Modules
  • Updated webpack config due to the update
  • package-lock.json
  • Initial setup of build and "dev-server" scripts in package.json for further development of astrum

Sources:

How can this be tested?

Install astrum and the "development mode" console warning should be gone.

Screenshots / Screencast

screen shot 2018-03-28 at 21 54 19

What gif best describes how you feel about this work?


Reviewers

Review 1

  • 👍

Review 2 (optional)

  • 👍

By adding a +1 you are confirming you have...

  • Witnessed the work behaving as expected (this could be on the author's machine or screencast).
  • Checked for coding anti-patterns.

@giothevanni
Copy link
Author

Hey @RyanHavoc & @hankchizljaw ,
finally got around to fixing this. It turned out to be a much bigger change than I anticipated. I'll be looking forward to your feedback.

Cheers!

@Andy-set-studio
Copy link
Contributor

Hey @giothevanni! Thanks for your hard work. We'll take a look at this next week 🙂

@giothevanni
Copy link
Author

Hey guys, have you had the chance to take a look at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants