Refactor the name service contract deployment #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the `SHOULD_DEPLOY` variable and improved the verification of environment variables required for deployment. * Rename ClickResolver to `UniversalResolver` contract to handle subdomain resolution based on names registered in L2 * Updated resolver addresses in the deployment script to use `NS_RESOLVER_ADDR` instead of `CLICK_RESOLVER_ADDR`. * Improved deployment logic to check if `CONTRACT_ADDRESS` is defined before proceeding with contract deployment.
ETeissonniere
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOULD_DEPLOYvariable and improved the verification of environment variables required for deployment.UniversalResolvercontract to handle subdomain resolution based on names registered in L2NS_RESOLVER_ADDRinstead ofCLICK_RESOLVER_ADDR.CONTRACT_ADDRESSis defined before proceeding with contract deployment.