Skip to content

Conversation

@0Xellos
Copy link
Contributor

@0Xellos 0Xellos commented Sep 22, 2025

Summary of changes:

  • bump uniffi-rs version to 0.29
  • bump its dependencies that are used for this bindgen: askama -> 0.13, cargo_metadata -> 0.19
  • remove cases for uniffi_bindgen::interface::Type::External since this enum value got removed
  • add a case for uniffi_bindgen::interface::FfiType::MutReference (identical to Reference) since this enum value got added
  • rename filter deref to cpp_deref, it was causing conflict with a new builtin filter
  • changed uniffi_bindgen::backend::TemplateExpression to String since this type got removed
  • added impl CustomTypesConfig; changed the use of into_custom and from_custom in custom.cpp template to lift and lower defined here
  • cast some names from String to &str
  • renamed iter_types to iter_local_types on ComponentInterface since that method got removed - this is what I'm least confident about in this PR, there are multiple methods returning type iterators...
  • renamed variable fn to func because of conflict with the Rust keyword
  • changed how filters get_*_definition are used: ci|get_*_definition(name) -> ci.get_*_definition(name).unwrap()
  • broke up filter chain {%- let ffi_converter_name = typ|ffi_converter_name|class_name %} in enum.hpp and err.hpp templates into 2 steps, was required to pass String as &str
  • rewrite custom type definitions in fixtures to use macro uniffi::custom_newtype

Disclaimer: I'm a C++ guy, not a Rust guy. I was mostly going by a similar update that was done in uniffi-bindgen-cs.

Signed-off-by: Jakub Safin <jakub.safin@innovatrics.com>
Copy link
Member

@Lipt0nas Lipt0nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MR looks good overall, thank you for contributing!

Signed-off-by: Jakub Safin <jakub.safin@innovatrics.com>

Co-authored-by: Martynas Gurskas <gurmart@gmail.com>
Signed-off-by: Jakub Safin <jakub.safin@innovatrics.com>
@tomas-krupa
Copy link

@Lipt0nas Hello, do you plan to merge this update in the near future? Thanks a lot.

Copy link
Member

@Lipt0nas Lipt0nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks in order, thanks for the patience and contribution 🙂

@Lipt0nas Lipt0nas merged commit c58776c into NordSecurity:main Dec 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants