Allow queuing priority messages in CAN #319
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a
int8_t queue_prio_can_msg(can_msg_t msg)Notes
This function is NOT dependent upon
queue_and_set_flags, but contains the same code. If we wanted to add a priority param toqueue_and_set_flags, we could consolidate code. We could also add a priority param toqueue_can_message, but I would advise against it asqueue_can_messageis already significantly used and we only want to distinguish between "priority" and "not piority"Test Cases
To Do
queue_and_set_flagsin Embedded Base (optional)queue_prio_can_messageChecklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #282