Skip to content

Port Percell to New Pack Config #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
caiodasilva2005 wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Port Percell to New Pack Config #43

caiodasilva2005 wants to merge 11 commits into from

Conversation

@caiodasilva2005
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 commented Dec 28, 2025 •
edited
Loading

Changes

  • Updated Debug Mode CAN messages to reflect new pack config
  • Calculating cell and chip diagnostic data in analyzer to send in new thread vDebug

To Do

  • fix mutexing on get cell data
  • enhance the per-cell timing

Checklist

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • PR is linked to the ticket (fill in the closes line below)

Closes #38

@caiodasilva2005 caiodasilva2005 self-assigned this Dec 28, 2025
@caiodasilva2005 caiodasilva2005 marked this pull request as ready for review January 5, 2026 22:52
jr1221
jr1221 reviewed Jan 5, 2026
View reviewed changes
Core/Inc/datastructs.h Outdated
float die_temp;

/* Chip and Cell Diagnostic Data */
bool is_balacing[NUM_CELLS_PER_CHIP];
Copy link
Contributor

@jr1221 jr1221 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balancing*

Core/Src/shep_tasks.c
void vDebug(ULONG thread_input)
{
analyzer_t *analyzer = (analyzer_t *)thread_input;

Copy link
Contributor

@jr1221 jr1221 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be perhaps nice to only trigger this thread when the vGetSegmentData is complete so we dont waste time running this too early.

Copy link
Contributor Author

@caiodasilva2005 caiodasilva2005 Jan 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes since. Made it so it runs after analyzer since that is where it is reading the data from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jr1221 jr1221 jr1221 left review comments

@KSMehta11 KSMehta11 Awaiting requested review from KSMehta11

At least 1 approving review is required to merge this pull request.

Assignees

@caiodasilva2005 caiodasilva2005

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port Percell Data Retrieval To TSECU

3 participants

@caiodasilva2005 @jr1221