Skip to content

Conversation

@Haselnussbomber
Copy link
Contributor

@Haselnussbomber Haselnussbomber commented Nov 30, 2025

In NotAdam/Lumina.Excel#11 we added ExcelPage and RowOffset properties to the generated sheet structs.
It would only make sense if we add those to the interfaces IExcelRow<T> and IExcelSubrow<T> too.

I had to rename the existing Page and Offset properties in RawRow and RawSubrow accordingly, which in turn also makes it much clearer what the offset is actually for.

Also updated:

  • everything to .NET 10
  • nuget dependencies
  • Lumina.Example to use the new sheets system
  • the CI workflow, but didn't touch the deprecated actions/create-release@v1 action.

But I can also remove those commits again, I don't mind either way.

@Haselnussbomber Haselnussbomber changed the title Expose ExcelPage and RowOffset through interfaces Upgrade to .NET 10, expose ExcelPage and RowOffset Nov 30, 2025
@NotAdam
Copy link
Owner

NotAdam commented Nov 30, 2025

sounds good to me, i'll try updating the create-release action for lols

@NotAdam NotAdam merged commit 178799f into NotAdam:master Nov 30, 2025
2 checks passed
@Haselnussbomber Haselnussbomber deleted the expose-excelpage branch December 1, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants