Skip to content

Upgrade to use DotNet Core 3.1 and dotnet cli for build #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
B3nCr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to use DotNet Core 3.1 and dotnet cli for build #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0509253
Convert to .NET Core 3.1
Aug 8, 2020
14d9643
Updated docs to remove reference to build.bat
Aug 8, 2020
c016db4
Update GildedRose.Tests.csproj
B3nCr Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
430 changes: 217 additions & 213 deletions .gitignore
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 0 additions & 6 deletions .nuget/NuGet.Config
View file
Open in desktop

This file was deleted.

Binary file removed .nuget/NuGet.exe
View file
Open in desktop
Binary file not shown.
112 changes: 0 additions & 112 deletions .nuget/NuGet.targets
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions .nuget/packages.config
View file
Open in desktop

This file was deleted.

46 changes: 21 additions & 25 deletions GildedRose.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,43 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 2013
VisualStudioVersion = 12.0.31101.0
# Visual Studio Version 16
VisualStudioVersion = 16.0.30320.27
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GildedRose.Tests", "src\GildedRose.Tests\GildedRose.Tests.csproj", "{CD4715A2-532E-4C74-BC40-36EE64F61FCA}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{21A00AD6-7CA9-4991-98A7-0E9BD6BDFF32}"
ProjectSection(SolutionItems) = preProject
.nuget\NuGet.Config = .nuget\NuGet.Config
.nuget\NuGet.targets = .nuget\NuGet.targets
.nuget\packages.config = .nuget\packages.config
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{E9B2B641-EF32-484B-8255-AA7AE68231D5}"
ProjectSection(SolutionItems) = preProject
MIT-LICENSE.txt = MIT-LICENSE.txt
README.md = README.md
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".build", ".build", "{B8B88B1C-EDE3-463E-AE8D-21A915B514F5}"
ProjectSection(SolutionItems) = preProject
build.bat = build.bat
tasks.ps1 = tasks.ps1
EndProjectSection
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{829221A4-ACDD-4E9D-95B3-FD2323AF98D2}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GildedRose.Console", "src\GildedRose.Console\GildedRose.Console.csproj", "{22A2292D-0D34-41DC-A01E-B6782EC137CB}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GildedRose.Console", "src\GildedRose.Console\GildedRose.Console.csproj", "{F2E879A9-7F1C-4C34-AB0D-2662F9815046}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GildedRose.Tests", "src\GildedRose.Tests\GildedRose.Tests.csproj", "{7B36F5D2-48D7-49BB-A384-5B802DCBE23E}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{CD4715A2-532E-4C74-BC40-36EE64F61FCA}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{CD4715A2-532E-4C74-BC40-36EE64F61FCA}.Debug|Any CPU.Build.0 = Debug|Any CPU
{CD4715A2-532E-4C74-BC40-36EE64F61FCA}.Release|Any CPU.ActiveCfg = Release|Any CPU
{CD4715A2-532E-4C74-BC40-36EE64F61FCA}.Release|Any CPU.Build.0 = Release|Any CPU
{F2E879A9-7F1C-4C34-AB0D-2662F9815046}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{F2E879A9-7F1C-4C34-AB0D-2662F9815046}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F2E879A9-7F1C-4C34-AB0D-2662F9815046}.Release|Any CPU.ActiveCfg = Release|Any CPU
{F2E879A9-7F1C-4C34-AB0D-2662F9815046}.Release|Any CPU.Build.0 = Release|Any CPU
{22A2292D-0D34-41DC-A01E-B6782EC137CB}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{22A2292D-0D34-41DC-A01E-B6782EC137CB}.Debug|Any CPU.Build.0 = Debug|Any CPU
{22A2292D-0D34-41DC-A01E-B6782EC137CB}.Release|Any CPU.ActiveCfg = Release|Any CPU
{22A2292D-0D34-41DC-A01E-B6782EC137CB}.Release|Any CPU.Build.0 = Release|Any CPU
{7B36F5D2-48D7-49BB-A384-5B802DCBE23E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{7B36F5D2-48D7-49BB-A384-5B802DCBE23E}.Debug|Any CPU.Build.0 = Debug|Any CPU
{7B36F5D2-48D7-49BB-A384-5B802DCBE23E}.Release|Any CPU.ActiveCfg = Release|Any CPU
{7B36F5D2-48D7-49BB-A384-5B802DCBE23E}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {F34FDAFD-7A14-4BAB-B80E-F6E74B58EAE3}
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{22A2292D-0D34-41DC-A01E-B6782EC137CB} = {829221A4-ACDD-4E9D-95B3-FD2323AF98D2}
{7B36F5D2-48D7-49BB-A384-5B802DCBE23E} = {829221A4-ACDD-4E9D-95B3-FD2323AF98D2}
EndGlobalSection
EndGlobal
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ Quality is 80 and it never alters.

## Getting Started

Clone the repository. Run build.bat from Powershell. If you see
Clone the repository. Run `dotnet test`. If you see
output similar to the following screenshot, you are ready to
start refactoring.

![alt text](images/build_output.png "Good Build Output")
![Test Run Successful. Total Tests: 1. Passed: 1 ](images/build_output.png "dotnet test output")

## Who, What, Why?
Who: [@TerryHughes](https://twitter.com/TerryHughes), [@NotMyself](https://twitter.com/NotMyself)
Expand Down
57 changes: 0 additions & 57 deletions build.bat
View file
Open in desktop

This file was deleted.

Binary file modified images/build_output.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
61 changes: 5 additions & 56 deletions src/GildedRose.Console/GildedRose.Console.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,59 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<ProjectGuid>{F2E879A9-7F1C-4C34-AB0D-2662F9815046}</ProjectGuid>
<OutputType>Exe</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>GildedRose.Console</RootNamespace>
<AssemblyName>GildedRose.Console</AssemblyName>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
<FileAlignment>512</FileAlignment>
<TargetFramework>netcoreapp3.1</TargetFramework>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
<OutputPath>bin\Release\</OutputPath>
<DefineConstants>TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
</ItemGroup>
<ItemGroup>
<Compile Include="Program.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>
<None Include="App.config" />
<None Include="packages.config" />
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
</Target>
<Target Name="AfterBuild">
</Target>
-->
</Project>

</Project>
9 changes: 5 additions & 4 deletions src/GildedRose.Console/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;

namespace GildedRose.Console
{
Expand All @@ -10,8 +11,8 @@ static void Main(string[] args)
System.Console.WriteLine("OMGHAI!");

var app = new Program()
{
Items = new List<Item>
{
Items = new List<Item>
{
new Item {Name = "+5 Dexterity Vest", SellIn = 10, Quality = 20},
new Item {Name = "Aged Brie", SellIn = 2, Quality = 0},
Expand All @@ -26,7 +27,7 @@ static void Main(string[] args)
new Item {Name = "Conjured Mana Cake", SellIn = 3, Quality = 6}
}

};
};

app.UpdateQuality();

Expand Down
Loading