[18.0][IMP] product_contract - add class o_row to auto_renew fields #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @sbejaoui, |
anthonissen-a
changed the title
mamcode
approved these changes
Oct 18, 2025
Member
mamcode
left a comment
mamcode
left a comment
There was a problem hiding this comment.
Thanks for this improvement @anthonissen-a
At the code level, I understand that this improvement adds consistency in layout and styling with the recurrence section, but visually I can't see any changes. In any case, I believe this is the correct way the code should be.
Author
|
Hi @mamcode, thanks for the review! In one of our projects, I had to make these fields readonly, and that's where the styling difference becomes noticeable. You can see the contrast in the screenshots below, with and without 
|
Member
|
@anthonissen-a Thanks, now it's clear to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
class="o_row"to the auto-renew divs to ensure consistent layout and styling with the recurrence section.