Skip to content

[16.0][IMP] base_geoengine: Fix Vector Layer related Error #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anusriNPS wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] base_geoengine: Fix Vector Layer related Error #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions base_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export class GeoengineRenderer extends Component {
this.orm = useService("orm");
this.view = useService("view");
this.user = useService("user");
this.notification = useService("notification");

// For related model we need to load all the service needed by RelationalModel
this.services = {};
Expand Down Expand Up @@ -749,8 +750,12 @@ export class GeoengineRenderer extends Component {
const fields_to_read = this.getFieldsToRead(vector);
const data = await this.getModelData(vector, fields_to_read);
this.useRelatedModel(vector, layer, data);
const styleInfo = this.styleVectorLayer(vector, data);
this.initLegend(styleInfo, vector);
if (this.checkAttributeFieldUsage(vector, data)) {
const styleInfo = this.styleVectorLayer(vector, data);
if (styleInfo) {
this.initLegend(styleInfo, vector);
}
}
}

async renderVectorLayers() {
Expand Down Expand Up @@ -844,9 +849,13 @@ export class GeoengineRenderer extends Component {
}

styleVectorLayerAndLegend(cfg, data, lv) {
const styleInfo = this.styleVectorLayer(cfg, data);
this.initLegend(styleInfo, cfg);
lv.setStyle(styleInfo.style);
if (this.checkAttributeFieldUsage(cfg, data)) {
const styleInfo = this.styleVectorLayer(cfg, data);
if (styleInfo) {
this.initLegend(styleInfo, cfg);
lv.setStyle(styleInfo.style);
}
}
}

initLegend(styleInfo, cfg) {
Expand Down Expand Up @@ -1248,6 +1257,27 @@ export class GeoengineRenderer extends Component {
var indicator = cfg.attribute_field_id[1];
return data.map((item) => item._values[indicator]);
}

/**
* Check vector Layer Attribute Field is defined
* by view to display proper legends
*/
checkAttributeFieldUsage(cfg, data) {
const indicator_values = this.extractLayerValues(cfg, data);
if (indicator_values.some((item) => typeof item === "undefined")) {
this.notification.add(
this.env._t(
"Customize view to use Attribute Field: " +
cfg.attribute_field_id[1]
),
{
type: "warning",
}
);
return false;
}
return true;
}
}

GeoengineRenderer.template = "base_geoengine.GeoengineRenderer";
Expand Down