-
-
Notifications
You must be signed in to change notification settings - Fork 195
[19.0][MIG] maintenance_plan #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
6e92ea7 to
52b1443
Compare
|
Hi @JasminSForgeFlow, dependency is merged. Can you please rebase and update the main PR comment? Thanks |
… equipment maintenance team is not filled [ADD] icon.png
[UPD] Update maintenance_plan.pot
Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/ [UPD] README.rst
…nt company maintenance_plan 12.0.1.1.0
[ADD] instructions and notes to Plan - Add menus for maintenance plans. - Set active button on maintenance plans. improve navigation to maintenance plans. [ADD] post-migration script
[UPD] Update maintenance_plan.pot [UPD] README.rst maintenance_plan 12.0.3.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/
[UPD] Update maintenance_plan.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/
Currently translated at 98.4% (63 of 64 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/
[UPD] Update maintenance_plan.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/
[UPD] Update maintenance_plan.pot maintenance_plan 13.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/ pre-commit update
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/
…patible. includes migration scripts
[UPD] Update maintenance_plan.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/
[UPD] Update maintenance_plan.pot [UPD] README.rst
Currently translated at 100.0% (69 of 69 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_plan/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-17.0/maintenance-17.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-17-0/maintenance-17-0-maintenance_plan/
Currently translated at 100.0% (115 of 115 strings) Translation: maintenance-17.0/maintenance-17.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-17-0/maintenance-17-0-maintenance_plan/it/
Without this fix, the smart button using the act_window fails with an error.
Currently translated at 100.0% (115 of 115 strings) Translation: maintenance-17.0/maintenance-17.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-17-0/maintenance-17-0-maintenance_plan/it/
Currently translated at 100.0% (115 of 115 strings) Translation: maintenance-17.0/maintenance-17.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-17-0/maintenance-17-0-maintenance_plan/it/
after this commit odoo/odoo@3bd8410 the maintenance request form view now has an independent page. This commit adapts the view to align with the new page structure.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-17.0/maintenance-17.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-17-0/maintenance-17-0-maintenance_plan/
- `maintenance.request` views are now set in their own file - `note` field replaced with existing combo `instruction_type,instruction_pdf,instruction_google_slide,instruction_text`
4db644e to
423f7a8
Compare
Done, Thanks |
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional + code ok, just pending to fix tests.
| cls.maintenance_plan_obj = cls.env["maintenance.plan"] | ||
| cls.maintenance_equipment_obj = cls.env["maintenance.equipment"] | ||
| cls.cron = cls.env.ref("maintenance_plan.maintenance_requests_cron") | ||
| cls.weekly_kind = cls.env.ref("maintenance_plan.maintenance_kind_weekly") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests wont load demo data, you have to create the record
Quan-nhm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
Standard Migration
@ForgeFlow
Depends on: