Skip to content

Conversation

@sbejaoui
Copy link

In the base repair module, consumption moves for spare parts are created and immediately validated when the repair order is marked as done. This prevents user interaction such as choosing lot/serial numbers.

This module introduces an optional intermediate step:

  • When enabled at warehouse level, repair consumption moves are grouped into a stock picking.
  • The repair order is set to a new Consumption state until the picking is validated.
  • Users can process the picking manually, assign lots/serials, and only then complete the repair.

cc/ @lmignon , @rousseldenis

@rousseldenis rousseldenis added this to the 16.0 milestone Aug 29, 2025
@sbejaoui sbejaoui force-pushed the 16.0-repair_stock_consumption_step-sbj branch from ddc5d42 to 0527711 Compare August 29, 2025 09:50
Copy link

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the base repair module, consumption moves for spare parts are
created and immediately validated when the repair order is marked as done.
This prevents user interaction such as choosing lot/serial numbers.

This module introduces an optional intermediate step:

- When enabled at warehouse level, repair consumption moves are grouped
  into a stock picking.
- The repair order is set to a new **Consumption** state until the picking
  is validated.
- Users can process the picking manually, assign lots/serials, and only
  then complete the repair.
@sbejaoui sbejaoui force-pushed the 16.0-repair_stock_consumption_step-sbj branch from 0527711 to aa305f9 Compare September 1, 2025 08:29
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 4, 2026
Copy link

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review + functional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants