[19.0][ADD] sale_portal_debranding: Remove Odoo branding from sale portal page

[jappi00]

Created my first module for this issue #115 . I tried to follow all guidelines and I hope I did everything right.

What it does?

Replace all references, except to the docs for integrations, from the "Connect youre System" Modal on the sale portal page

[jappi00]

Hello @pedrobaeza,

I'am not sure if I did anything wrong here and how I can progress from here. Maybe you can give me a hint?

Have a nice evening,

Jappi00

[pedrobaeza]

Hello @jappi00 it seems correct. Now, you have to find reviewers

https://odoo-community.org/page/review

You can review other PRs, and ask in exchange that they review yours.

[ljmnoonan]

Thank you for your work!

Honestly, I do think this should be a part of portal_debranding as it is already doing stuff similar to what this module does, so I would suggest opening a new PR as such.

[ljmnoonan]

I highly recommend a more thorough description of where exactly this modal is, and possibly a screenshot as well.

[jappi00]

I have tuned the description a little bit.

[jappi00]

Thank you for your work!

Honestly, I do think this should be a part of portal_debranding as it is already doing stuff similar to what this module does, so I would suggest opening a new PR as such.

Was my first idea too. But that module do not depend on sale. We would take away the possibility to use the portal debranding module for users which only use purchase and not the sale module.

[jappi00]

And @ljmnoonan, thanks for the review. I appreciate it! I’ll update it shortly.

[ljmnoonan]

But that module do not depend on sale. We would take away the possibility to use the portal debranding module for users which only use purchase and not the sale module.

Ahh, I see. I wonder if there is a way to make a view "optional" and not crash everything if it does not find its parent. I'll have to look into it

[jappi00]

But that module do not depend on sale. We would take away the possibility to use the portal debranding module for users which only use purchase and not the sale module.

Ahh, I see. I wonder if there is a way to make a view "optional" and not crash everything if it does not find its parent. I'll have to look into it

I don't think so but it would be a good thing since we have the exact same modal on purchase and this would mean we would need one more module. Maybe we could autoinstall those modules with the portal debranding?

[pedrobaeza]

This module should be an extra one, as the base one can't depend on sale.

[jappi00]

@ljmnoonan Sorry, I strugeled a little bit with pre-commit. I hope I solved everything. Not sure if the more defined xpath / view is good. Was a little bit hard to find a good way for targeting the right elements.

[ljmnoonan]

Functional test is good!
A few nitpicks which you can ignore if you want :)

[jappi00]

Functional test is good!
A few nitpicks which you can ignore if you want :)

Fixed those. 🫡