-
Notifications
You must be signed in to change notification settings - Fork 33
update: beanie version, drop motor dependency #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Beanie 1.29.0 is the latest version available for Python 3.8, hence, the failing tests... |
|
Another note on Beanie, currently the dependencies are as follows: Motor, the async MongoDB driver, is slated for deprecation around May 2026. Beanie v2+ already has native PyMongo async support and the motor dependency could be dropped. Beanie -> Async PyMongo -> MongoDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let's track that upcoming removal in a separate issue.
I don't understand why the tests fail, beanie v2.0.1 should be available for >= 3.9 but
.
It is not for 3.8 though, understandably but unfortunately, that's the failing test.
|
We're only keeping support for end-of-life 3.8 because of processors that cannot be readily updated to 3.9 because they require tensorflow 1.*. However, as of now, this only pertains to two projects now (https://github.com/OCR-D/ocrd_keraslm/ and https://github.com/ASVLeipzig/cor-asv-ann/) and the maintainer will find a way to update those ASAP (🙏 @bertsky). Since there are no fat containers in ocrd_all anymore that required a least common python version 3.8, I will release this now as-is so everything except those two projects is properly working again. |
Not yet: ocrd_all:master is still a fat container, and its :maximum images only build if the TF1 components can be installed. But as long as we don't make new ocrd/all releases in that paradigm, we should be fine. And of course, OCR-D/ocrd_all#468 (bringing mutual independence of modules) is coming... BTW, @kba, looking at the CD failures here, I believe you now need to modify the base image from ubuntu:20.04 to at least 22.04 to make it work. |
Version update for beanie to work with pydantic v2 for local installations. I forgot to add that to #1348. Not sure how the ocrd_network pipeline tests have passed with
beanie<=2.0andpydantic >=2.0. Should fail with:This PR is also important to fix dependency issues in Operandi caused by version mismatches of Beanie between core 3.9.1 and operandi_utils.