HYRAX-1670: remove bes container access calls #1241
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added a ticket (HYRAX-1987) to address the larger issue regarding how the module's code is built.
Member
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
This coming along. Thanks. When this passes it's tests, it can be merged.
| // expensive, even when the container is intelligently written (DMR++ documents | ||
| // can be many megabytes in size). Fix this mess so that get_container_type() | ||
| // works without all of the handlers calling access() twice. jhrg 2/18/25 | ||
| // temporary disable to see what breaks SBL - 12.20.25 |
Member
There was a problem hiding this comment.
These comments should be updated. This part of the BES is fairly convoluted and we're going to want reminders of what is going on here - that FileContainer has one behavior but others like NgapOwnedContainer have this odd two-part operation that is now done using a second method unique to the DMR++ module.
| build_dmrpp_h4_LDFLAGS = $(HDFEOS2_LDFLAGS) $(HDF4_LDFLAGS) $(BES_DAP_LIB_LDFLAGS) | ||
|
|
||
| # jhrg 12/18/23 $(top_builddir)/dap/.libs/libdap_module.a | ||
| # TODO Fix this kludge: $(builddir)/../.libs/libdmrpp_module.a. The code above in dmrpp_module |
Member
There was a problem hiding this comment.
This is another comment that will need updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changed the function of NgapOwnedContainer::access() to just set the container type and added a secondary fct called alt_access() that does the previous functionality of access()
changed the dmrppRequestHandler::get_dmrpp_from_container_or_cache() to use the alt_access() fct
Tasks