Update java versions #95
Conversation
| && python3 --version | ||
|
|
||
| RUN set -e && dnf install -y make curl unzip which autoconf automake emacs vim jq \ | ||
| RUN set -e \ |
There was a problem hiding this comment.
I'm confused---I don't remember seeing a PR for the hyrax-docker changes that would move from builds to el-builds, but they're renamed here; did I miss something?
There was a problem hiding this comment.
Ah, looks like that change was merged sans PR: 6d96515
Request for PRs in the future! (I thought we had pushing direct to master blocked, but I guess it's still possible to force push... even when time sensitive, I still think it would be better to have a PR that is merged without waiting for review, so that it at least goes through the CI/CD pipeline pre-merge and is more visible to the rest of us.)
There was a problem hiding this comment.
Ah, looks like that change was merged sans PR: 6d96515
I think in the frenzy of working with 2 repos and 4 branches that I thought I was on a branch when I committed and pushed those changes...
| && echo "Enabled $j_vers" \ | ||
| && java -version \ | ||
|
|
||
| # java_sdk_11 |
There was a problem hiding this comment.
non-blocking, but: while you're already updating these builds, want to appened the RUN commands on 131 and 134 and 138 into this RUN command, so that we don't save a layer with extra stuff before we run our clean all? (ditto in the ngap builds as well)
Today Hannah and I discovered that despite various docker images installing java-11 or java-21, all of the docker images are using java 8 . This is because the Docker builds failed to use
update-alternativesto set the current java version.This PR should address this issue:
RHEL8:
RHEL9: