Slurm: total_nodes probably shouldn't account for down/unavailable nodes #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total nodes shouldn't account for nodes marked as down in Slurm, as this might look misleading in certain widgets like System Status. Have also broken out unavailable nodes as a new property if directly modifying total_nodes isn't considered ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes that are marked as unavailable/down in Slurm, along with their processors, probably shouldn't be counted in the
total_nodesandtotal_processorsfigure, as this leads to misleading numbers in certain areas such as the System Status, which advertises more nodes and processors available than there really are. This is made possible by adjusting the sinfo command called bynode_cpu_infoto use%Finstead of%A.This is more of a proposal at the moment so I've also added an
unavailable_nodesfield that breaks out the down/unavailable node field, if directly modifyingtotal_nodesandtotal_processorsisn't considered ideal or breaks some things, however this way would either need this replicated across all other adapters, or a special check added incluster_info.rbfor Slurm.