Skip to content

fix(ci): fix link-checker context and prevent deploy on PR #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItsCurulo wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −4
Open

fix(ci): fix link-checker context and prevent deploy on PR #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e738657
fix(ci): fix link-checker context and prevent deploy on PR
ItsCurulo Dec 28, 2025
9ab73ea
Fix: Move link checker logic to pr.yaml
ItsCurulo Dec 29, 2025
ed0a265
Fix: Move link checker logic to pr.yaml
ItsCurulo Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Lint markdown
uses: DavidAnson/markdownlint-cli2-action@v22.0.0
with:
config: '.markdownlint.yaml'
config: ".markdownlint.yaml"
Copy link
Contributor

@jgadsden jgadsden Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for a change to double quotes here, as no escape sequences are expected, so can be reverted

globs: |
docs/**/*.md
docs/*.md
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Set up Python for PT-BR
uses: actions/setup-python@v6.1.0
with:
python-version: '3.10'
python-version: "3.10"

Copy link
Contributor

@jgadsden jgadsden Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for line 49

- name: Install pyspelling for PT-BR
run: |
Expand All @@ -89,6 +89,7 @@ jobs:
deploy:
name: Deploy web doc
runs-on: ubuntu-latest

needs: [md_linter, spell_checker]
Copy link
Contributor

@jgadsden jgadsden Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ne need for new line

steps:
- name: Checkout markdown
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
steps:
- name: Checkout markdown
uses: actions/checkout@v6.0.1
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
Copy link
Contributor

@jgadsden jgadsden Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is implied by the pull request action and so is not needed


- name: Link Checker
uses: lycheeverse/lychee-action@v2.7.0
Expand All @@ -39,7 +41,7 @@ jobs:
- name: Lint markdown
uses: DavidAnson/markdownlint-cli2-action@v22.0.0
with:
config: '.markdownlint.yaml'
config: ".markdownlint.yaml"
Copy link
Contributor

@jgadsden jgadsden Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above, no need for double quotes as there are no escape sequences, same for line 86

globs: |
docs/**/*.md
docs/*.md
Expand Down Expand Up @@ -81,7 +83,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v6.1.0
with:
python-version: '3.10'
python-version: "3.10"

- name: Install pyspelling
run: |
Expand Down