-
Notifications
You must be signed in to change notification settings - Fork 61
Fix: Improve Search Bar Icon Sharpness and CSS Cleanup #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Great job! thank you |
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these changes needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these dependency changes are not needed for the CSS update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
such updates in packages is unlikely to be necessary for css changes, can you please revert the dependency changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I've reverted yarn.lock and removed package-lock.json from the PR to keep it CSS-only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, then please resolve conflicts and let's merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All conflicts resolved and dependency changes reverted.
PR is CSS-only and ready to merge. Thanks!
248b2fb to
06f02a5
Compare
Fixes #649
Summary
This PR improves the SearchBar UI by fixing the blurry search icon and enhancing visibility.
Changes
Notes
Tested locally on multiple screen sizes.