Optimize shell scripts and eliminate Nix configuration duplication

[Copilot]

Identified and resolved performance bottlenecks in shell scripts and redundant patterns in Nix configuration.

Shell Script Optimizations

• Array construction: Replaced array=($(command)) with mapfile -t array < <(command) to avoid subshell overhead and word splitting issues
• Variable quoting: Fixed unquoted variable expansions preventing globbing/word splitting vulnerabilities
• Useless processes: Eliminated cat file | wc -l → wc -l < file
• Loop efficiency: Converted for x in $(cmd) to while read -r x; do to avoid subshell spawning per iteration
• Cleanup: Removed malformed bru.sh and unused zscroll2.sh

Before (random-wallpaper.sh):

WALLPAPERS=($(find -L "$WALLPAPER_DIR" -type f \( -iname "*.jpg" ... \) 2>/dev/null))

After:

mapfile -t WALLPAPERS < <(find -L "$WALLPAPER_DIR" -type f \( -iname "*.jpg" ... \) 2>/dev/null)

Nix Configuration Refactoring

Eliminated ~30 lines of repeated home-manager and system configuration boilerplate via helper functions:

# Before: Repeated for each host
laptop = nixpkgs.lib.nixosSystem {
  specialArgs = { inherit inputs; };
  modules = commonModules ++ [
    ./hosts/laptop
    { user = "none"; }
    { home-manager = { useGlobalPkgs = true; ... }; }
  ];
};

# After: DRY with helper function
laptop = mkSystem {
  hostPath = ./hosts/laptop;
  user = "none";
};

Hyprland Startup

Split chained exec-once command ("hyprpanel & script.sh & swaync") into separate entries for proper parallel startup and cleaner failure isolation.

Bug Fixes

• Fixed undefined variable in waybar-wttr.py format_temp() function
• Corrected [ ! -z $var ] → [ -n "$var" ] pattern

All changes pass shellcheck with zero warnings. CodeQL scan clean.

Original prompt

Identify and suggest improvements to slow or inefficient code

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.