Skip to content

Fix SFTP integration tests by configuring writable chroot directory #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Menelion merged 2 commits into from
Jan 13, 2026
+251 −254
Merged

Fix SFTP integration tests by configuring writable chroot directory #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
110db58
Initial plan
Copilot Jan 13, 2026
7d71e1e
Fix SFTP test configuration for chrooted environment
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
380 changes: 190 additions & 190 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,190 +1,190 @@
# This workflow will build a .NET project
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net
name: .NET
on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: Cleanup previous test services
run: |
echo "=== Cleaning up any previous test services ==="
docker compose -f docker-compose.test.yml down -v --remove-orphans || true
sudo rm -rf /tmp/localstack || true
echo "=== Removing stale Docker volumes ==="
docker volume rm sharp-sync_sftp-data || true
docker volume rm sharp-sync_ftp-data || true
docker volume rm sharp-sync_webdav-data || true
- name: Start test services
run: |
echo "=== Starting test services with docker-compose ==="
docker compose -f docker-compose.test.yml up -d
- name: Wait for services to be ready
run: |
echo "=== Waiting for services to be healthy ==="
docker compose -f docker-compose.test.yml ps
echo "=== Waiting for SFTP server ==="
for i in {1..18}; do
nc -z localhost 2222 && echo "SFTP ready" && break
echo "SFTP not ready, retrying in 5 seconds... ($i/18)"
sleep 5
done
echo "=== Waiting for FTP server ==="
for i in {1..18}; do
nc -z localhost 21 && echo "FTP ready" && break
echo "FTP not ready, retrying in 5 seconds... ($i/18)"
sleep 5
done
echo "=== Waiting for LocalStack ==="
for i in {1..30}; do
curl -sf http://localhost:4566/_localstack/health && echo "LocalStack ready" && break
echo "LocalStack not ready, retrying in 10 seconds... ($i/30)"
sleep 10
done
echo "=== Waiting for WebDAV server ==="
WEBDAV_BASIC_READY=false
for i in {1..30}; do
if curl -sf -u testuser:testpass http://localhost:8080/ > /dev/null 2>&1; then
echo "WebDAV responding to basic requests"
WEBDAV_BASIC_READY=true
break
fi
echo "WebDAV not responding, retrying in 5 seconds... ($i/30)"
sleep 5
done
if [ "$WEBDAV_BASIC_READY" = "false" ]; then
echo "ERROR: WebDAV server not responding after 30 attempts"
docker compose -f docker-compose.test.yml logs webdav
exit 1
fi
echo "=== Checking WebDAV full functionality (MKCOL) ==="
WEBDAV_FULLY_READY=false
for i in {1..40}; do
# Show verbose output for debugging
echo "Attempt $i: Testing MKCOL operation..."
MKCOL_RESULT=$(curl -s -w "%{http_code}" -u testuser:testpass -X MKCOL http://localhost:8080/_health-check-dir/ -o /dev/null 2>&1)
echo "MKCOL response code: $MKCOL_RESULT"
if [ "$MKCOL_RESULT" = "201" ] || [ "$MKCOL_RESULT" = "405" ]; then
echo "WebDAV is fully operational (MKCOL working)"
# Cleanup test directory
curl -sf -u testuser:testpass -X DELETE http://localhost:8080/_health-check-dir/ > /dev/null 2>&1 || true
WEBDAV_FULLY_READY=true
break
fi
# Show container status and logs on failures
if [ $((i % 5)) -eq 0 ]; then
echo "--- WebDAV container status ---"
docker compose -f docker-compose.test.yml ps webdav
echo "--- Recent WebDAV logs ---"
docker compose -f docker-compose.test.yml logs --tail=10 webdav
fi
echo "MKCOL not working yet, retrying in 5 seconds..."
sleep 5
done
if [ "$WEBDAV_FULLY_READY" = "false" ]; then
echo "ERROR: WebDAV MKCOL not working after 40 attempts"
echo "=== Full WebDAV logs ==="
docker compose -f docker-compose.test.yml logs webdav
exit 1
fi
echo "=== Final service status ==="
docker compose -f docker-compose.test.yml ps
- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
- name: Restore dependencies
run: dotnet restore
- name: Check format
run: dotnet format --verify-no-changes
- name: Build
run: dotnet build --no-restore
- name: Create S3 test bucket
run: |
docker exec sharp-sync-localstack-1 awslocal s3 mb s3://test-bucket
- name: Debug WebDAV setup
run: |
echo "=== WebDAV Container Status ==="
docker compose -f docker-compose.test.yml ps webdav
echo ""
echo "=== WebDAV Container Logs ==="
docker compose -f docker-compose.test.yml logs webdav
echo ""
echo "=== Testing WebDAV Operations ==="
echo "PROPFIND (list root):"
curl -s -w "\nHTTP Status: %{http_code}\n" -u testuser:testpass -X PROPFIND http://localhost:8080/ -H "Depth: 1" | head -30
echo ""
echo "PUT (write test):"
echo "test content" | curl -s -w "\nHTTP Status: %{http_code}\n" -u testuser:testpass -X PUT http://localhost:8080/_debug-test.txt -d @-
echo ""
echo "DELETE (cleanup):"
curl -s -w "\nHTTP Status: %{http_code}\n" -u testuser:testpass -X DELETE http://localhost:8080/_debug-test.txt
- name: Prepare WebDAV test root
run: |
echo "=== Creating WebDAV test root directory ==="
# Delete existing test root if present
curl -sf -u testuser:testpass -X DELETE http://localhost:8080/ci-root/ --output /dev/null 2>&1 || true
# Create fresh test root
curl -sf -u testuser:testpass -X MKCOL http://localhost:8080/ci-root/
echo "WebDAV test root created successfully"
- name: Test
run: dotnet test --no-build --verbosity normal
env:
SFTP_TEST_HOST: localhost
SFTP_TEST_PORT: 2222
SFTP_TEST_USER: testuser
SFTP_TEST_PASS: testpass
SFTP_TEST_ROOT: ""
FTP_TEST_HOST: localhost
FTP_TEST_PORT: 21
FTP_TEST_USER: testuser
FTP_TEST_PASS: testpass
FTP_TEST_ROOT: ""
S3_TEST_BUCKET: test-bucket
S3_TEST_ACCESS_KEY: test
S3_TEST_SECRET_KEY: test
S3_TEST_ENDPOINT: http://localhost:4566
S3_TEST_PREFIX: sharpsync-tests
WEBDAV_TEST_URL: http://localhost:8080/
WEBDAV_TEST_USER: testuser
WEBDAV_TEST_PASS: testpass
WEBDAV_TEST_ROOT: "ci-root"
- name: Dump container logs
if: failure()
run: |
echo "=== Container logs for debugging ==="
docker compose -f docker-compose.test.yml logs
- name: Stop test services
if: always()
run: |
docker compose -f docker-compose.test.yml down -v --remove-orphans || true
# This workflow will build a .NET project
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net

name: .NET

on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6

- name: Cleanup previous test services
run: |
echo "=== Cleaning up any previous test services ==="
docker compose -f docker-compose.test.yml down -v --remove-orphans || true
sudo rm -rf /tmp/localstack || true
echo "=== Removing stale Docker volumes ==="
docker volume rm sharp-sync_sftp-data || true
docker volume rm sharp-sync_ftp-data || true
docker volume rm sharp-sync_webdav-data || true

- name: Start test services
run: |
echo "=== Starting test services with docker-compose ==="
docker compose -f docker-compose.test.yml up -d

- name: Wait for services to be ready
run: |
echo "=== Waiting for services to be healthy ==="
docker compose -f docker-compose.test.yml ps

echo "=== Waiting for SFTP server ==="
for i in {1..18}; do
nc -z localhost 2222 && echo "SFTP ready" && break
echo "SFTP not ready, retrying in 5 seconds... ($i/18)"
sleep 5
done

echo "=== Waiting for FTP server ==="
for i in {1..18}; do
nc -z localhost 21 && echo "FTP ready" && break
echo "FTP not ready, retrying in 5 seconds... ($i/18)"
sleep 5
done

echo "=== Waiting for LocalStack ==="
for i in {1..30}; do
curl -sf http://localhost:4566/_localstack/health && echo "LocalStack ready" && break
echo "LocalStack not ready, retrying in 10 seconds... ($i/30)"
sleep 10
done

echo "=== Waiting for WebDAV server ==="
WEBDAV_BASIC_READY=false
for i in {1..30}; do
if curl -sf -u testuser:testpass http://localhost:8080/ > /dev/null 2>&1; then
echo "WebDAV responding to basic requests"
WEBDAV_BASIC_READY=true
break
fi
echo "WebDAV not responding, retrying in 5 seconds... ($i/30)"
sleep 5
done

if [ "$WEBDAV_BASIC_READY" = "false" ]; then
echo "ERROR: WebDAV server not responding after 30 attempts"
docker compose -f docker-compose.test.yml logs webdav
exit 1
fi

echo "=== Checking WebDAV full functionality (MKCOL) ==="
WEBDAV_FULLY_READY=false
for i in {1..40}; do
# Show verbose output for debugging
echo "Attempt $i: Testing MKCOL operation..."
MKCOL_RESULT=$(curl -s -w "%{http_code}" -u testuser:testpass -X MKCOL http://localhost:8080/_health-check-dir/ -o /dev/null 2>&1)
echo "MKCOL response code: $MKCOL_RESULT"

if [ "$MKCOL_RESULT" = "201" ] || [ "$MKCOL_RESULT" = "405" ]; then
echo "WebDAV is fully operational (MKCOL working)"
# Cleanup test directory
curl -sf -u testuser:testpass -X DELETE http://localhost:8080/_health-check-dir/ > /dev/null 2>&1 || true
WEBDAV_FULLY_READY=true
break
fi

# Show container status and logs on failures
if [ $((i % 5)) -eq 0 ]; then
echo "--- WebDAV container status ---"
docker compose -f docker-compose.test.yml ps webdav
echo "--- Recent WebDAV logs ---"
docker compose -f docker-compose.test.yml logs --tail=10 webdav
fi

echo "MKCOL not working yet, retrying in 5 seconds..."
sleep 5
done

if [ "$WEBDAV_FULLY_READY" = "false" ]; then
echo "ERROR: WebDAV MKCOL not working after 40 attempts"
echo "=== Full WebDAV logs ==="
docker compose -f docker-compose.test.yml logs webdav
exit 1
fi

echo "=== Final service status ==="
docker compose -f docker-compose.test.yml ps

- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
- name: Restore dependencies
run: dotnet restore
- name: Check format
run: dotnet format --verify-no-changes
- name: Build
run: dotnet build --no-restore
- name: Create S3 test bucket
run: |
docker exec sharp-sync-localstack-1 awslocal s3 mb s3://test-bucket

- name: Debug WebDAV setup
run: |
echo "=== WebDAV Container Status ==="
docker compose -f docker-compose.test.yml ps webdav
echo ""
echo "=== WebDAV Container Logs ==="
docker compose -f docker-compose.test.yml logs webdav
echo ""
echo "=== Testing WebDAV Operations ==="
echo "PROPFIND (list root):"
curl -s -w "\nHTTP Status: %{http_code}\n" -u testuser:testpass -X PROPFIND http://localhost:8080/ -H "Depth: 1" | head -30
echo ""
echo "PUT (write test):"
echo "test content" | curl -s -w "\nHTTP Status: %{http_code}\n" -u testuser:testpass -X PUT http://localhost:8080/_debug-test.txt -d @-
echo ""
echo "DELETE (cleanup):"
curl -s -w "\nHTTP Status: %{http_code}\n" -u testuser:testpass -X DELETE http://localhost:8080/_debug-test.txt

- name: Prepare WebDAV test root
run: |
echo "=== Creating WebDAV test root directory ==="
# Delete existing test root if present
curl -sf -u testuser:testpass -X DELETE http://localhost:8080/ci-root/ --output /dev/null 2>&1 || true
# Create fresh test root
curl -sf -u testuser:testpass -X MKCOL http://localhost:8080/ci-root/
echo "WebDAV test root created successfully"

- name: Test
run: dotnet test --no-build --verbosity normal
env:
SFTP_TEST_HOST: localhost
SFTP_TEST_PORT: 2222
SFTP_TEST_USER: testuser
SFTP_TEST_PASS: testpass
SFTP_TEST_ROOT: upload
FTP_TEST_HOST: localhost
FTP_TEST_PORT: 21
FTP_TEST_USER: testuser
FTP_TEST_PASS: testpass
FTP_TEST_ROOT: ""
S3_TEST_BUCKET: test-bucket
S3_TEST_ACCESS_KEY: test
S3_TEST_SECRET_KEY: test
S3_TEST_ENDPOINT: http://localhost:4566
S3_TEST_PREFIX: sharpsync-tests
WEBDAV_TEST_URL: http://localhost:8080/
WEBDAV_TEST_USER: testuser
WEBDAV_TEST_PASS: testpass
WEBDAV_TEST_ROOT: "ci-root"

- name: Dump container logs
if: failure()
run: |
echo "=== Container logs for debugging ==="
docker compose -f docker-compose.test.yml logs

- name: Stop test services
if: always()
run: |
docker compose -f docker-compose.test.yml down -v --remove-orphans || true
Loading