Coding - Refactoring BOPDS #1007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtheneNoctuaPt
added
2. Enhancement
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the BOPDS (Boolean Operation Data Structure) module by refactoring code to use modern C++ idioms, improving naming conventions, and adding convenience constructors.
Changes:
- Modernized C++ code using range-based for loops, structured bindings, and initializer lists
- Improved parameter and variable naming throughout the codebase for clarity
- Added parameterized constructors for
BOPDS_PaveandBOPDS_IndexRangeclasses
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| BOPDS_Pave.lxx | Modernized constructor implementation using initializer lists; added parameterized constructor |
| BOPDS_Pave.hxx | Added parameterized constructor declaration |
| BOPDS_IndexRange.lxx | Added parameterized constructor implementation |
| BOPDS_IndexRange.hxx | Added parameterized constructor declaration |
| BOPDS_DS.hxx | Improved parameter naming and documentation across multiple methods |
| BOPDS_DS.cxx | Extensive refactoring with modern C++ idioms, improved naming, added helper functions, and new GetSameDomainIndex method |
AtheneNoctuaPt
force-pushed
the
refactor_BOPDS_DS
branch
from
c5abd79 to
93c4463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.