Improve Singapore Address Format #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Singaporean address format is described in this Mail Quality Guide from Singapore Post: https://www.singpost.com/sites/default/files/2022-10/Mail%20Quality%20Guide%20v201106.pdf.
I know that this template collection is not specifically concerned with generating perfect postal addresses, but it seems clear that duplicating the country isn't expected. In a postal setting, the final line should always be just "Singapore" and the postal code.
The other fallbacks seem a bit suspect to be honest, but I'm sure someone is using them so I've made the smallest possible change and removed the duplicate country.