Skip to content

Symfony 4 Compatibility #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azoog wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Symfony 4 Compatibility #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions Resources/config/services.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@
<argument type="string">%openclassrooms_onesky.api_secret%</argument>
</call>
</service>
<service id="openclassrooms.onesky.event_dispatcher" class="Symfony\Component\EventDispatcher\EventDispatcher"/>
<service id="openclassrooms.onesky.gateways.file" class="OpenClassrooms\Bundle\OneSkyBundle\Gateways\Impl\FileGatewayImpl">
<service id="openclassrooms.onesky.event_dispatcher" class="Symfony\Component\EventDispatcher\EventDispatcher" public="true"/>
<service id="openclassrooms.onesky.gateways.file" class="OpenClassrooms\Bundle\OneSkyBundle\Gateways\Impl\FileGatewayImpl" public="true">
<call method="setClient">
<argument type="service" id="openclassrooms.onesky.client"/>
</call>
<call method="setEventDispatcher">
<argument type="service" id="openclassrooms.onesky.event_dispatcher"/>
</call>
</service>
<service id="openclassrooms.onesky.gateways.language" class="OpenClassrooms\Bundle\OneSkyBundle\Gateways\Impl\LanguageGatewayImpl">
<service id="openclassrooms.onesky.gateways.language" class="OpenClassrooms\Bundle\OneSkyBundle\Gateways\Impl\LanguageGatewayImpl" public="true">
<call method="setClient">
<argument type="service" id="openclassrooms.onesky.client"/>
</call>
Expand All @@ -28,7 +28,7 @@
<argument type="string">%openclassrooms_onesky.project_id%</argument>
</call>
</service>
<service id="openclassrooms.onesky.model.file_factory" class="OpenClassrooms\Bundle\OneSkyBundle\Model\Impl\FileFactoryImpl">
<service id="openclassrooms.onesky.model.file_factory" class="OpenClassrooms\Bundle\OneSkyBundle\Model\Impl\FileFactoryImpl" public="true">
<call method="setKeepingAllStrings">
<argument type="string">%openclassrooms_onesky.keep_all_strings%</argument>
</call>
Expand All @@ -45,21 +45,21 @@
<argument type="string">%openclassrooms_onesky.source_locale%</argument>
</call>
</service>
<service id="openclassrooms.onesky.model.language_factory" class="OpenClassrooms\Bundle\OneSkyBundle\Model\Impl\LanguageFactoryImpl"/>
<service id="openclassrooms.onesky.services.file_service" class="OpenClassrooms\Bundle\OneSkyBundle\Services\Impl\FileServiceImpl">
<service id="openclassrooms.onesky.model.language_factory" class="OpenClassrooms\Bundle\OneSkyBundle\Model\Impl\LanguageFactoryImpl" public="true"/>
<service id="openclassrooms.onesky.services.file_service" class="OpenClassrooms\Bundle\OneSkyBundle\Services\Impl\FileServiceImpl" public="true">
<call method="setFileGateway">
<argument type="service" id="openclassrooms.onesky.gateways.file"/>
</call>
</service>
<service id="openclassrooms.onesky.services.language_service" class="OpenClassrooms\Bundle\OneSkyBundle\Services\Impl\LanguageServiceImpl">
<service id="openclassrooms.onesky.services.language_service" class="OpenClassrooms\Bundle\OneSkyBundle\Services\Impl\LanguageServiceImpl" public="true">
<call method="setLanguageGateway">
<argument type="service" id="openclassrooms.onesky.gateways.language"/>
</call>
<call method="setRequestedLocales">
<argument>%openclassrooms_onesky.locales%</argument>
</call>
</service>
<service id="openclassrooms.onesky.services.translation_service" class="OpenClassrooms\Bundle\OneSkyBundle\Services\Impl\TranslationServiceImpl">
<service id="openclassrooms.onesky.services.translation_service" class="OpenClassrooms\Bundle\OneSkyBundle\Services\Impl\TranslationServiceImpl" public="true">
<call method="setEventDispatcher">
<argument type="service" id="openclassrooms.onesky.event_dispatcher"/>
</call>
Expand All @@ -82,5 +82,17 @@
<argument type="string">%openclassrooms_onesky.source_locale%</argument>
</call>
</service>
<service id="OpenClassrooms\Bundle\OneSkyBundle\Command\CheckTranslationProgressCommand" public="true">
<tag name="console.command" />
</service>
<service id="OpenClassrooms\Bundle\OneSkyBundle\Command\PullCommand" public="true">
<tag name="console.command" />
</service>
<service id="OpenClassrooms\Bundle\OneSkyBundle\Command\PushCommand" public="true">
<tag name="console.command" />
</service>
<service id="OpenClassrooms\Bundle\OneSkyBundle\Command\UpdateCommand" public="true">
<tag name="console.command" />
</service>
</services>
</container>
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
},
"require": {
"onesky/api-library-php5": "1.*",
"symfony/dependency-injection": ">=2.7 <4",
"symfony/console": ">=2.7 <4",
"symfony/config": ">=2.7 <4",
"symfony/finder": ">=2.7 <4",
"symfony/framework-bundle": ">=2.7 <4",
"symfony/http-kernel": ">=2.7 <4"
"symfony/dependency-injection": "~2.7|~3.0|~4.0",
"symfony/console": "~2.7|~3.0|~4.0",
"symfony/config": "~2.7|~3.0|~4.0",
"symfony/finder": "~2.7|~3.0|~4.0",
"symfony/framework-bundle": "~2.7|~3.0|~4.0",
"symfony/http-kernel": "~2.7|~3.0|~4.0"
},
"require-dev": {
"fabpot/php-cs-fixer": "1.*",
Expand Down
Loading