Skip to content

Conversation

@IamLRBA
Copy link
Contributor

@IamLRBA IamLRBA commented Jan 6, 2026

Pull Request Title

Improve UI Spacing and Error Button Visibility

Description

This PR implements UI improvements to maximize usable screen space by reducing unnecessary margins, borders, and padding throughout the Formplayer interface. Additionally, it enhances the finalization page by converting error list items to clearly visible, clickable buttons.

Key Changes:

  • Reduced padding in main app container (12px → 4px)
  • Reduced form screen padding and margins (2vh → 0.5vh, 15px → 8px)
  • Reduced horizontal padding (1% → 0.5%)
  • Reduced navigation bar padding and removed top border
  • Reduced content bottom padding (120px → 80px)
  • Reduced React Native modal header padding and close button padding
  • Converted error list items to styled buttons for better visibility and UX

Type of Change

  • Bug Fix
  • New Feature / Enhancement
  • Refactor / Code Cleanup
  • Documentation Update
  • Maintenance / Chore
  • Other (please specify):

Component(s) Affected

  • formulus (React Native mobile app)
  • formulus-formplayer (React web app)
  • synkronus (Go backend server)
  • synkronus-cli (Command-line utility)
  • Documentation
  • DevOps / CI/CD
  • Other:

Related Issue(s)

Closes/Fixes/Resolves: Closes #151


Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manually tested
  • Tested on multiple platforms (if applicable)
  • Not applicable

Testing Notes:

  • Tested in browser development environment
  • Verified responsive behavior across different screen sizes
  • Confirmed error button clickability and navigation functionality
  • Tested form layout with reduced spacing

New Error Buttons:
Capture


Breaking Changes

  • This PR introduces breaking changes
  • This PR does NOT introduce breaking changes

If breaking changes, please describe migration steps:


Documentation Updates

  • Documentation has been updated
  • Documentation update is not required

Checklist

  • Code follows project style guidelines
  • All existing tests pass
  • New tests added for new functionality
  • PR title follows Conventional Commits format

Thank you for contributing to Open Data Ensemble (ODE)!

Copy link
Contributor

@najuna-brian najuna-brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top Padding Too Small?
On my mobile, the reduction of padding-top from 2vh to 0.5vh in index.css (line 20) is causing the first form entries (consent questions, etc.) to be cut off at the top. May be we can increase this to at least 1.5vh or 2vh to ensure content is fully visible?

Progress Bar Positioning:
The design feedback requested moving the progress bar "all the way up" to maximize vertical space. This hasn't been addressed 😄 We could consider reducing/removing this margin and adjusting header padding in FormLayout.tsx to move it higher as @r0ssing showed in the screenshot

Could we have something like this?

  • index.css line 20: Change padding-top: 0.5vh;padding-top: 1.5vh; (or 2vh)
  • FormProgressBar.tsx line 169: Consider reducing mb: 2 to mb: 0.5 or mb: 1
  • App.tsx line 653: Consider if padding: '4px' is too tight - maybe 8px as a middle ground

Thoughts?

The close button margin reductions look good
The finalize screen looks great 🎉

@r0ssing
Copy link
Contributor

r0ssing commented Jan 7, 2026

Looks good! Perhaps if we could win some space by letting the "Please fix" text simply replace the "Review and Finalize"-title? (we might not need both). Also - do we know how wide those pill buttons can become? I am thinking it would maybe look nice if we could give them a fixed width instead? What do we think?

r0ssing
r0ssing previously approved these changes Jan 7, 2026
@IamLRBA
Copy link
Contributor Author

IamLRBA commented Jan 7, 2026

Thanks for testing this Brian.
I will make the changes accordingly.

@IamLRBA
Copy link
Contributor Author

IamLRBA commented Jan 7, 2026

Looks good! Perhaps if we could win some space by letting the "Please fix" text simply replace the "Review and Finalize"-title? (we might not need both).

Thanks @r0ssing,
I understand the "Review and Finalize" is the main heading for this page and evidently, the "Please fix the following errors before finalizing:" text only appears if there are errors.
But we have a "Form Summary" heading bellow the errors which could in turn act as our main heading with the subtext "Review all your entered data below. Click on any field to edit it.".
Your point is valid and I second it.

@IamLRBA
Copy link
Contributor Author

IamLRBA commented Jan 7, 2026

Also - do we know how wide those pill buttons can become? I am thinking it would maybe look nice if we could give them a fixed width instead? What do we think?

This was me doing the opposite of what needed to be done in doubts of it being what is actually required!
Initially, as per the pill button rules, the pills all have the same length that span just like the form summary. And their widths can widen according to the length of the error texts.

Since, that is clearly the better Idea, I will work on reverting to that instead. 👍🏽👍🏽

@IamLRBA
Copy link
Contributor Author

IamLRBA commented Jan 8, 2026

@r0ssing I reorganized the headings to win some space. Error buttons now have uniform width for better visual consistency. The "Form Summary" section is now styled as the main heading with bold typography.

Capture

How's it looking?

Copy link
Contributor

@Bahati308 Bahati308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IamLRBA, this is dope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Formplayer] UI improvements

4 participants