-
Notifications
You must be signed in to change notification settings - Fork 8
feat(formplayer): improve UI spacing and error button visibility #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top Padding Too Small?
On my mobile, the reduction of padding-top from 2vh to 0.5vh in index.css (line 20) is causing the first form entries (consent questions, etc.) to be cut off at the top. May be we can increase this to at least 1.5vh or 2vh to ensure content is fully visible?
Progress Bar Positioning:
The design feedback requested moving the progress bar "all the way up" to maximize vertical space. This hasn't been addressed 😄 We could consider reducing/removing this margin and adjusting header padding in FormLayout.tsx to move it higher as @r0ssing showed in the screenshot
Could we have something like this?
index.cssline 20: Changepadding-top: 0.5vh;→padding-top: 1.5vh;(or2vh)FormProgressBar.tsxline 169: Consider reducingmb: 2tomb: 0.5ormb: 1App.tsxline 653: Consider ifpadding: '4px'is too tight - maybe8pxas a middle ground
Thoughts?
The close button margin reductions look good
The finalize screen looks great 🎉
|
Looks good! Perhaps if we could win some space by letting the "Please fix" text simply replace the "Review and Finalize"-title? (we might not need both). Also - do we know how wide those pill buttons can become? I am thinking it would maybe look nice if we could give them a fixed width instead? What do we think? |
|
Thanks for testing this Brian. |
Thanks @r0ssing, |
This was me doing the opposite of what needed to be done in doubts of it being what is actually required! Since, that is clearly the better Idea, I will work on reverting to that instead. 👍🏽👍🏽 |
|
@r0ssing I reorganized the headings to win some space. Error buttons now have uniform width for better visual consistency. The "Form Summary" section is now styled as the main heading with bold typography. How's it looking? |
Bahati308
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IamLRBA, this is dope!
Pull Request Title
Improve UI Spacing and Error Button Visibility
Description
This PR implements UI improvements to maximize usable screen space by reducing unnecessary margins, borders, and padding throughout the Formplayer interface. Additionally, it enhances the finalization page by converting error list items to clearly visible, clickable buttons.
Key Changes:
Type of Change
Component(s) Affected
Related Issue(s)
Closes/Fixes/Resolves: Closes #151
Testing
Testing Notes:
New Error Buttons:

Breaking Changes
If breaking changes, please describe migration steps:
Documentation Updates
Checklist
Thank you for contributing to Open Data Ensemble (ODE)!