Skip to content

Conversation

@Mishael-2584
Copy link
Contributor

@Mishael-2584 Mishael-2584 commented Jan 14, 2026

Description

Automatically commits built Formplayer assets to PR branches, eliminating manual asset management. Assets are included when PRs are merged. For protected branches (main/dev), the workflow builds assets and uploads them as artifacts instead of committing directly.

Key Changes:

  • Commits assets directly to PR branches (not protected, so commits allowed)
  • Skips commits to protected branches, uploads artifacts instead
  • Simplified path filtering (removed redundant negation pattern)
  • Improved workflow naming and organization

Type of Change

  • Bug Fix
  • New Feature / Enhancement
  • Refactor / Code Cleanup
  • Documentation Update
  • Maintenance / Chore
  • Other (please specify):

Component(s) Affected

  • formulus (React Native mobile app)
  • formulus-formplayer (React web app)
  • synkronus (Go backend server)
  • synkronus-cli (Command-line utility)
  • Documentation
  • Other: DevOps / CI/CD

Related Issue(s)

Fixes: #233 Workflow failure when pushing assets to protected branches, requiring manual asset management.


Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manually tested
  • Tested on multiple platforms (if applicable)
  • Not applicable

Testing:

  1. Create PR with formplayer code changes → verify assets committed to PR branch
  2. Push to protected branch → verify workflow skips commit, uploads artifact
  3. Push to non-protected branch → verify assets committed directly

Breaking Changes

  • This PR introduces breaking changes
  • This PR does NOT introduce breaking changes

Documentation Updates

  • Documentation has been updated
  • Documentation update is not required

Checklist

  • Code follows project style guidelines
  • All existing tests pass
  • New tests added for new functionality
  • PR title follows Conventional Commits format

Mishael-2584 and others added 2 commits January 14, 2026 10:15
- Automatically commit built formplayer assets to PR branches
- Assets are included when PR is merged, no manual steps needed
- Respects protected branch rules (main/dev require PRs)
- Simplified path filtering (removed redundant negation pattern)
- Improved workflow naming and organization
@Mishael-2584 Mishael-2584 changed the title feat(ci): auto-commit formplayer assets to PR branches feat(ci): auto-commit formplayer assets to PR branches Jan 14, 2026
@Mishael-2584 Mishael-2584 requested a review from r0ssing January 14, 2026 07:25
@Mishael-2584
Copy link
Contributor Author

@r0ssing Trying this updated action fix that commits the assets to the PR branch on changes, so we can merge them together with the PR. I don't know if that would solve this issue we have.

Copy link
Contributor

@r0ssing r0ssing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Mishael-2584 Mishael-2584 merged commit 3c9c971 into dev Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Formplayer bundle to the CI/CD pipeline

3 participants