embedded-usb-pd: Audit panics #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtjd
force-pushed
the
audit-panics
branch
2 times, most recently
from
e86645b to
5e04e7d
Compare
asasine
requested changes
Dec 19, 2025
Contributor
jerrysxie
previously approved these changes
Dec 23, 2025
asasine
approved these changes
Dec 23, 2025
Contributor
Author
Will announce this on Zulip and submit a PR for embedded-services. |
Contributor
Author
embedded-services PR: OpenDevicePartnership/embedded-services#664 |
jerrysxie
pushed a commit
to OpenDevicePartnership/embedded-services
that referenced
this pull request
Dec 24, 2025
Updates repo to the latest de-panicked `embedded-usb-pd`: OpenDevicePartnership/embedded-usb-pd#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR audits potential panics. Most were cases that are easily proven to never panic (assuming the assumptions in the code are held) and these assumptions are defined very close to the potential panic path, so I think it was safe to allow these instead of returning an error.
A refactor of the
Argstype may help eliminate the need for unwraps (see: #61).Rdo::for_pdonow returns anOption<Self>and is public so a minor breaking change has been introduced.Resolves #59