-
Notifications
You must be signed in to change notification settings - Fork 534
Add support for Janitza UMG806 (via UMG604 Master) #3449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
According to the docs "[the open-pull-requests-limit] option has no impact on security updates, which have a separate, internal limit of ten open pull requests".
|
Just because I am curious - is it also possible to Connect to the UMG806 directly without the Master? |
The Janitza UMG 806 meter itself does not support Modbus TCP, as it does not have an RJ45 interface. It is possible to achieve this using the UMG806-EC1 expansion module or as done via a master-slave architecture with a UMG604 as the master providing the ethernet connection. |
Well possibly we should then mention this somewhere as this is not documented yet, right? |
Where do you suggest to document it? That the extension is needed is described on the product page of Janitza already? |
I actually would suggest to write a Hint in the Readme of the Janitza Package or in the Config. |
Comprehensible 😉 A hint at the modbus bridge would then be appropriate I guess, e.g. "ID of Modbus bridge to use. This type of meter can by default only be connected via Modbus TCP enabled master device like the UMG604." |
sfeilmeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done. I don't have permissions to edit your PR, so I'll do the remaining changes and cleanups in a separate PR directly on develop.
Thank you for the contribution! 🚀
| @Override | ||
| protected ModbusProtocol defineModbusProtocol() { | ||
| var modbusProtocol = new ModbusProtocol(this, | ||
| // Register: 19000–19010 → Spannungen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments should be in English language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translated with efd35ef
|
Ah... unfortunately I cannot fix the conflicts myself. Please update this PR to develop. Please also add JUnit tests if possible for both implementations. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3449 +/- ##
==============================================
- Coverage 59.54% 29.13% -30.40%
==============================================
Files 2901 291 -2610
Lines 124935 8116 -116819
Branches 9357 1386 -7971
==============================================
- Hits 74381 2364 -72017
+ Misses 47737 5629 -42108
+ Partials 2817 123 -2694 🚀 New features to boost your workflow:
|
Overview
This pull request adds support for the Janitza UMG806 energy meter.
In our setup, the UMG806 is connected as a Modbus RTU device behind a Janitza UMG604 acting as the master.
OpenEMS communicates with the UMG604 via Modbus TCP, and the UMG806 registers are accessed through this chain. When using a UMG604 as a gateway, the configuration must use the IP address of the UMG604 and the Modbus unit ID, which references the RTU input ID of the UMG806.
The implementation has been fully tested with real hardware (UMG806 + UMG604) at our demonstration site.
This development was carried out within the OMEI project, funded by the German Federal Ministry for Digital and Transport (BMDV).
Included Functionality
Technical Notes
Testing
Credits
A big thank you goes to @himiflo, Ralf and @schiegg for creating, integrating, and evaluating this component.
References