Skip to content

Conversation

@Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Nov 28, 2025

Summary

  • Fixed navigation sidebar persisting incorrectly when navigating from device view to overview page
  • Disabled new UI navigation on settings pages (/device/{id}/settings) which don't have navigation tree support
  • Added URL-based check in setPosition() to properly disable navigation on global pages

How to test:

  • Enable new UI in user settings
  • Navigate to /device/{edgeId}/live - sidebar should be visible
  • Click "Alle Systeme" to go to /overview - sidebar should disappear
  • Navigate to /device/{edgeId}/settings - sidebar should not be visible
  • Navigate back to /device/{edgeId}/live - sidebar should reappear

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3452      +/-   ##
=============================================
- Coverage      59.62%   59.62%   -0.00%     
  Complexity       112      112              
=============================================
  Files           2894     2894              
  Lines         124658   124672      +14     
  Branches        9343     9345       +2     
=============================================
+ Hits           74318    74326       +8     
- Misses         47522    47537      +15     
+ Partials        2818     2809       -9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant