#1528: Hibernate CTE support #1529
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1529 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 813 840 +27
Lines 31466 31845 +379
Branches 3614 3631 +17
=======================================
- Misses 31466 31845 +379
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| private void handleJoinTarget(JoinExpression je) { | ||
| protected void handleJoinTarget(JoinExpression je) { |
There was a problem hiding this comment.
I couldn't find a nicer way to extend the logic of this method.
As NativeSQLSerializer also has a similarly named method, which is also marked as protected I hope this is okay to do.
| public Q with(Path<?> alias, SubQueryExpression<?> query) { | ||
| return with(alias, null, query); | ||
| } |
There was a problem hiding this comment.
Hibernate only supports subqueries here, so there is no WithBuilder options here.
Also, recursive CTEs are not in scope for this change, so those are also not present.
| handle(alias); | ||
| withAliases.add(alias); | ||
| append(" as "); | ||
| if (args.get(1) instanceof ConstantImpl<?> materializedParam | ||
| && materializedParam.getConstant() instanceof Boolean materialized) { | ||
| if (!materialized) { | ||
| append("not "); | ||
| } | ||
| append("materialized "); | ||
| } | ||
| handle(args.get(2)); |
There was a problem hiding this comment.
Originally I wanted to use templates, but I couldn't figure out how to get the (not)? materialized part work with them. So I just append directly here.
...-libraries/querydsl-jpa/src/main/java/com/querydsl/jpa/hibernate/AbstractHibernateQuery.java
Outdated
Show resolved
Hide resolved
Extending AbstractHibernateQuery to support simple Common Table Expressions.
Mart1031y
force-pushed
the
feature/1528-hibernate-cte-support
branch
from
1fcdb17 to
c219fd9
Compare
|
CodeQL build is failing due to commit: 7f244eb. |
1 participant
Extending AbstractHibernateQuery to support simple Common Table Expressions.