BREAKING: Rename --max-attempts to --n-critic-runs #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaking change renames the parameter across the codebase to better reflect its purpose: controlling the number of critic evaluation runs in iterative mode, not general retry attempts. Changes: - CLI argument: --max-attempts → --n-critic-runs - Model field: max_attempts → n_critic_runs (EvalMetadata) - Updated all run_infer.py files (7 benchmarks) - Updated core logic (evaluation.py, iterative.py) - Updated test files (4 files) - Updated documentation (2 README files) Migration guide: - Update CLI usage: --max-attempts 3 → --n-critic-runs 3 - Update EvalMetadata construction: max_attempts= → n_critic_runs= Co-authored-by: openhands <openhands@all-hands.dev>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the
--max-attemptsparameter to--n-critic-runsacross the benchmarks codebase to better reflect its purpose: controlling the number of critic evaluation runs in iterative mode.Changes
--max-attempts→--n-critic-runsmax_attempts→n_critic_runs(EvalMetadata)Breaking Changes
This is a breaking change for users. Existing scripts and workflows must be updated.
Migration Required
--max-attempts 3→--n-critic-runs 3EvalMetadata(max_attempts=3)→EvalMetadata(n_critic_runs=3)Related PRs
This PR is part of a coordinated change. A corresponding PR will be created for the evaluation repo.
Testing