Fix websocket disconnect handling to avoid server shutdown #1636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the secondary issue from #1633: websocket disconnect handling that could potentially cause server instability.
Problem
When websocket connections encountered
ConnectionError, these exceptions were being re-raised along withRuntimeError, which could potentially cause server instability.Solution
Modified websocket handlers to:
ConnectionErrorgracefully (connection-related errors are safe to suppress)RuntimeErrorto surface actual bugs (as suggested in code review)except ConnectionErrorclause instead ofisinstancecheck (cleaner)Changes
sockets.py: Modifiedevents_socketandbash_events_socketto handleConnectionErrorgracefully while still re-raisingRuntimeErrortest_event_router_websocket.py: Updated test to verifyRuntimeErroris still re-raisedChecklist
Fixes #1633 (partial - websocket disconnect fix)
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:f2091f2-pythonRun
All tags pushed for this build
About Multi-Architecture Support
f2091f2-python) is a multi-arch manifest supporting both amd64 and arm64f2091f2-python-amd64) are also available if needed