Skip to content

Conversation

@KennyPlus
Copy link
Contributor

Change index check offset

Change index check offset
@josephnef
Copy link
Collaborator

@vertexodessa What was the purpose of changing EEPROM_TX_PWR_INX_8812 index from 0x10 to 0x20 in (PR#16)[https://github.com//pull/16]?

The same question about it for @KennyPlus but this time changing it to 0x22?

@KennyPlus
Copy link
Contributor Author

for ignore the 2G detection of the driver initialize, which causes NIC driver loading crashes.

@josephnef
Copy link
Collaborator

We cannot change it in every single PR back and forth. Let’s figure out how to change it from a constant to a configurable setting instead.

@KennyPlus
Copy link
Contributor Author

We cannot change it in every single PR back and forth. Let’s figure out how to change it from a constant to a configurable setting instead.

This offset is constant and it's a fixed address on HW.

@vertexodessa
Copy link
Contributor

hi @josephnef sorry about the confusion and late reply.

The point of the fix for Bonnet is to switch from checking presence of power calibration values in 2.4GHz range, to 5.8GHz range, since 2.4GHz range is not calibrated in Bonnet (values are all 0xFF).

While my fix also works, fix from @KennyPlus is more correct because it's using correct offset for 5.8GHz range calibration values
please merge this PR

@vertexodessa
Copy link
Contributor

vertexodessa commented Jul 28, 2025

it doesn't need to be configurable, the correct value is 0x22 as suggested by Kenny

@josephnef josephnef merged commit 797b6dd into OpenIPC:master Jul 28, 2025
3 checks passed
@josephnef
Copy link
Collaborator

Now it’s clear, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants