Skip to content

fix: incorrect scope with missing self #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danaford wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: incorrect scope with missing self #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b01425c
fix: incorrect scope with missing self
Mar 23, 2023
f842c93
fix: syntax warning with py3.8, identity vs equality check
Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions IfxAlchemy/IfxPy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def do_execute(self, cursor, statement, parameters, context=None):
_isolation_levels_returned = { value : key for key, value in _isolation_levels_cli.items()}

def _get_cli_isolation_levels(self, level):
return _isolation_levels_cli[level]
return self._isolation_levels_cli[level]

def set_isolation_level(self, connection, level):
if level is None:
Expand All @@ -143,7 +143,7 @@ def set_isolation_level(self, connection, level):
"Valid isolation levels for %s are %s" %
(level, self.name, ", ".join(self._isolation_lookup))
)
attrib = {SQL_ATTR_TXN_ISOLATION:_get_cli_isolation_levels(self,level)}
attrib = {SQL_ATTR_TXN_ISOLATION: self._get_cli_isolation_levels(level)}
res = connection.set_option(attrib)

def reset_isolation_level(self, connection):
Expand Down
4 changes: 2 additions & 2 deletions IfxAlchemy/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,9 @@ def visit_select(self, select, **kwargs):
sql = '%s, ( ROW_NUMBER() OVER() ) AS "%s" FROM ( %s ) AS M' % ( sql_sel, __rownum, sql_pri )
sql = '%s FROM ( %s ) Z WHERE' % ( sql_sel, sql )

if offset is not 0:
if offset != 0:
sql = '%s "%s" > %d' % ( sql, __rownum, offset )
if offset is not 0 and limit is not None:
if offset != 0 and limit is not None:
sql = '%s AND ' % ( sql )
if limit is not None:
sql = '%s "%s" <= %d' % ( sql, __rownum, offset + limit )
Expand Down