Remove empty extensionmanager-client.jar #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaffigan
approved these changes
Jul 12, 2025
|
That's not needed for the extensions view? Gets referenced in places like: |
pacmano1
approved these changes
Jul 12, 2025
Member
Author
See my comment in the description that the classes are included in mirth-client.jar instead and the related commit. The classes are in a different package than where this build step is looking. |
Member
Author
This is run from a nextgen mirth 4.5.0 docker container. You can see there are no class files in it. mirth@f874da704e65:/opt/connect$ unzip -l extensions/extensionmanager/extensionmanager-client.jar
Archive: extensions/extensionmanager/extensionmanager-client.jar
Length Date Time Name
--------- ---------- ----- ----
180 2024-01-17 12:29 META-INF/MANIFEST.MF
231 2024-01-17 12:30 META-INF/SERVER.SF
8994 2024-01-17 12:30 META-INF/SERVER.RSA
0 2024-01-17 12:28 META-INF/
--------- -------
9405 4 files |
gibson9583
approved these changes
Jul 12, 2025
kpalang
approved these changes
Jul 13, 2025
kpalang
force-pushed
the
remove-extensionmanager-jar
branch
from
b30cfa2 to
40a0bb9
Compare
ExtensionManager apparently used to be a plugin, but it has not been for some time. The step in the client build script that produced the extension jar was not removed at the same time and has been producing an effectively empty jar file with no classes and only a manifest. The actual extensionmanager related classes are included in mirth-client.jar. Related: 027ae24 Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
force-pushed
the
remove-extensionmanager-jar
branch
from
40a0bb9 to
df42f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionManager apparently used to be a plugin, but it has not been for some time. The step in the client build script that produced the extension jar was not removed at the same time and has been producing an effectively empty jar file with no classes and only a manifest. The actual extensionmanager related classes are included in mirth-client.jar.
Related: 027ae24