Skip to content

Centralized branding #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tonygermano merged 1 commit into from
May 30, 2025
Merged

Centralized branding #23

tonygermano merged 1 commit into from
May 30, 2025

Conversation

@kpalang
Copy link
Contributor

@kpalang kpalang commented Apr 8, 2025 •
edited
Loading

This PR gathers together all places where branding is used, to make it easier to build white-label spins of OpenIntegrationEngine.

Closes #4

gibson9583
gibson9583 reviewed Apr 8, 2025
View reviewed changes
@kpalang kpalang force-pushed the feature/centralized-branding branch from 9756a2c to 788dc0b Compare April 8, 2025 11:40
jonbartels
jonbartels requested changes Apr 8, 2025
View reviewed changes
@kpalang kpalang marked this pull request as draft April 9, 2025 07:21
@jonbartels jonbartels mentioned this pull request Apr 10, 2025
Closed
jonbartels
jonbartels previously approved these changes Apr 11, 2025
View reviewed changes
kryskool
kryskool reviewed Apr 12, 2025
View reviewed changes
jonbartels
jonbartels previously approved these changes Apr 14, 2025
View reviewed changes
tonygermano
tonygermano reviewed Apr 18, 2025
View reviewed changes
@kpalang kpalang force-pushed the feature/centralized-branding branch 3 times, most recently from 39e72c9 to c416225 Compare May 1, 2025 13:41
@kpalang kpalang marked this pull request as ready for review May 1, 2025 13:45
jonbartels
jonbartels requested changes May 1, 2025
View reviewed changes
Copy link
Contributor

@jonbartels jonbartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the comments in BrandingConstants.

Someone like a graphic designer or CEO should be able to look at this file and know what to update so that OIE becomes their company tool.

The comments in BrandingConstants should explain, in tiny words, what to do to a non-developer to brand the app

NicoPiel
NicoPiel reviewed May 1, 2025
View reviewed changes
NicoPiel

This comment was marked as off-topic.

Sign in to view

tonygermano
tonygermano requested changes May 2, 2025
View reviewed changes
Copy link
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thing is big! This is my first pass. I'm going to actually build and run it now so I can see how things look. Great work!

tonygermano
tonygermano requested changes May 2, 2025
View reviewed changes
Copy link
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round two. Additionally, the following things which are not marked specifically in the diff need to be addressed. Since these things are somewhat separate from the java code, it might be reasonable to just create a document pointing to where all of the changes need to be made.

  • question: do we want to change the plugin urls from nextgen.com?
  • todo: the default webadmin login page needs to be rebranded
  • todo: the swagger page still has Nextgen graphics at the top
  • todo: there are 3 project-info.java files that describe the User API packages which display in the javadoc pages and still refer to Mirth Connect.

@kpalang
Copy link
Contributor Author

kpalang commented May 4, 2025

@jonbartels
Agree on that the FAVICON should have the scale attached.

Someone like a graphic designer or CEO should be able to look at this file and know what to update

I disagree on the above though. OIE in it's current state is not ready for non-technical rebranding. There should be an engineer present for this and they should be able to navigate Java well enough to figure this out. We should be as helpful as possible, but this is a large enough tool that people working on it should have knowledge of the language.

jonbartels
jonbartels requested changes May 5, 2025
View reviewed changes
Copy link
Contributor

@jonbartels jonbartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first login and notification changes are blocking.

I am OK with defaults changing but not hardcoding to block the functionality because this kind of change is not in scope for a branding PR

@tonygermano
Copy link
Member

tonygermano commented May 5, 2025

Round two. Additionally, the following things which are not marked specifically in the diff need to be addressed. Since these things are somewhat separate from the java code, it might be reasonable to just create a document pointing to where all of the changes need to be made.

  • question: do we want to change the plugin urls from nextgen.com?
  • todo: the default webadmin login page needs to be rebranded
  • todo: the swagger page still has Nextgen graphics at the top
  • todo: there are 3 project-info.java files that describe the User API packages which display in the javadoc pages and still refer to Mirth Connect.

Not sure where you are at with the work right now, but let's handle this tasklist for non-java related changes in a separate PR. This PR is big enough already.

@kpalang kpalang force-pushed the feature/centralized-branding branch from 682bd0e to 2de2e28 Compare May 6, 2025 18:46
@kpalang kpalang requested a review from jonbartels May 6, 2025 18:56
@kpalang kpalang force-pushed the feature/centralized-branding branch from 5df1f5e to 9cbc8a5 Compare May 6, 2025 19:13
tonygermano
tonygermano requested changes May 7, 2025
View reviewed changes
jbeckers
jbeckers approved these changes May 13, 2025
View reviewed changes
Copy link

@jbeckers jbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

tonygermano
tonygermano reviewed May 13, 2025
View reviewed changes
kpalang
kpalang commented May 15, 2025
View reviewed changes
Copy link
Contributor Author

@kpalang kpalang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am the author of this PR, I cannot mark the PR as approved, but I am approving @tonygermano's latest commits.

jonbartels
jonbartels previously approved these changes May 15, 2025
View reviewed changes
@kpalang kpalang requested a review from tonygermano May 15, 2025 13:03
jonbartels
jonbartels previously approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@jonbartels jonbartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all the open comments have been addressed and that this PR is ready to merge

gibson9583
gibson9583 previously approved these changes May 27, 2025
View reviewed changes
@kpalang @tonygermano
#4 Whitelabel engine
e2b5878 
Co-authored-by: Tony Germano <tony@germano.name>
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
Signed-off-by: Tony Germano <tony@germano.name>
@tonygermano tonygermano dismissed stale reviews from gibson9583 and jonbartels via e2b5878 May 28, 2025 00:53
@tonygermano tonygermano force-pushed the feature/centralized-branding branch from 9a30da9 to e2b5878 Compare May 28, 2025 00:53
@tonygermano
Copy link
Member

tonygermano commented May 28, 2025

rebased and squashed, so this should be ready to merge now

@tonygermano tonygermano merged commit e2b5878 into main May 30, 2025
2 checks passed
@tonygermano tonygermano deleted the feature/centralized-branding branch May 30, 2025 10:13
@tonygermano tonygermano mentioned this pull request May 30, 2025
Open
@gibson9583 gibson9583 mentioned this pull request May 30, 2025
Closed
4 tasks
tonygermano added a commit to tonygermano/engine that referenced this pull request Jun 11, 2025
@tonygermano
Rebranding for mostly non-Java elements; New default webpage
8e6a11e 
Updated branding in plugin metadata
Updated branding in javadoc package files
Shortened task names in side-bar menu by excluding the product name
Fixed a typo in DicomListener
Updated branding on Client API web page
Fixed file permissions on a couple graphics that were marked executable
Removed webadmin from build and distribution
Replaced default webpage

Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
Relates-to: OpenIntegrationEngine#23
sbraconnier pushed a commit to sbraconnier/oie-engine that referenced this pull request Jul 19, 2025
@tonygermano @sbraconnier
Rebranding for mostly non-Java elements; New default webpage
888470a 
Updated branding in plugin metadata
Updated branding in javadoc package files
Shortened task names in side-bar menu by excluding the product name
Fixed a typo in DicomListener
Updated branding on Client API web page
Fixed file permissions on a couple graphics that were marked executable
Removed webadmin from build and distribution
Replaced default webpage

Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
Relates-to: OpenIntegrationEngine#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kayyagari kayyagari kayyagari approved these changes

@gibson9583 gibson9583 gibson9583 approved these changes

@jonbartels jonbartels jonbartels approved these changes

@tonygermano tonygermano tonygermano approved these changes

@kryskool kryskool Awaiting requested review from kryskool

@pacmano1 pacmano1 Awaiting requested review from pacmano1

@NicoPiel NicoPiel Awaiting requested review from NicoPiel

+1 more reviewer

@jbeckers jbeckers jbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Centralize the branding configuration

10 participants

@kpalang @tonygermano @kayyagari @kryskool @jbeckers @gibson9583 @jonbartels @NicoPiel @pacmano1