Skip to content

Bug - Fix CLI login error #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguel-figueiredoPT wants to merge 8 commits into
base: main
Choose a base branch
from
+17 −5
Open

Bug - Fix CLI login error #231

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
edfb6a8
Fix CLI login error
miguel-figueiredoPT Dec 22, 2025
6f6a8df
Implement review changes
miguel-figueiredoPT Dec 22, 2025
8e627c0
Implement suggestion
miguel-figueiredoPT Dec 22, 2025
3d7063e
Use LoginStatus.isSuccess() to evaluate login result
miguel-figueiredoPT Dec 22, 2025
8cb1b58
Use new java syntax
miguel-figueiredoPT Dec 23, 2025
0ebf5d4
Update exit codes + Cleanup
miguel-figueiredoPT Dec 31, 2025
10e6da1
Cleanup
miguel-figueiredoPT Dec 31, 2025
0cb7d2c
Merge remote-tracking branch 'upstream/main' into feature/224-fix-cli…
miguel-figueiredoPT Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions command/src/com/mirth/connect/cli/CommandLineInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import com.mirth.connect.client.core.PaginatedEventList;
import com.mirth.connect.client.core.PaginatedMessageList;
import com.mirth.connect.client.core.PropertiesConfigurationUtil;
import com.mirth.connect.client.core.UnauthorizedException;
import com.mirth.connect.donkey.model.channel.DeployedState;
import com.mirth.connect.donkey.model.message.ContentType;
import com.mirth.connect.donkey.model.message.Message;
Expand Down Expand Up @@ -179,11 +180,22 @@ private void runShell(String server, String user, String password, String script
client = new Client(server);
this.debug = debug;

LoginStatus loginStatus = client.login(user, password);

if (loginStatus.getStatus() != LoginStatus.Status.SUCCESS) {
error("Could not login to server.", null);
return;
LoginStatus loginStatus = null;
try {
loginStatus = client.login(user, password);
} catch (UnauthorizedException ex) {
if (ex.getResponse() instanceof LoginStatus status && status.isSuccess()) {
loginStatus = status;
}
}
finally {
if (loginStatus == null) {
error("Could not login to server");
System.exit(70);
}
else if (!loginStatus.isSuccess()) {
error("Could not login to server. Please check your username and password and try again.", null); System.exit(77);
}
}

String serverVersion = client.getVersion();
Expand Down
Loading