Fix a couple problems with setting the limit frame #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwdev01
reviewed
Jan 25, 2026
Contributor
bwdev01
left a comment
bwdev01
left a comment
There was a problem hiding this comment.
Is there something that makes the ZWO SDK unique in this respect?
Contributor
Author
cam_zwo is the only camera right now that has support for frame limit ROI. |
When we added software binning, we introduced some problems handling the frame limit ROI. - when setting the frame limit via the server API, set the limit corresponding to the combined (hw+sw) binning level, not the bin-1 limit. - when capturing a camera frame in Camera_ZWO::Capture, use the limit frame passed in the capture params which is the proper limit for hw-only binning , not the Camera instance's LimitFrame member which incorporates hw+sw binning.
agalasso
force-pushed
the
andy/limit-frame-bug-fixes
branch
from
5c49355 to
1abebfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple problems with setting the limit frame
When we added software binning, we introduced some problems handling the
frame limit ROI.
to the combined (hw+sw) binning level, not the bin-1 limit.
passed in the capture params which is the proper limit for hw-only binning , not
the Camera instance's LimitFrame member which incorporates hw+sw binning.