ZWO ASI camera: workaround quirk for ROI changing size but not changing position #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalasso
force-pushed
the
andy/zwo-asi-camera-roi-quirk-workaround
branch
from
000c8d8 to
a900f62
Compare
bwdev01
approved these changes
Jan 31, 2026
…ng position When the ROI size changes without the ROI position changing, the camera returns an invalid frame not matching the expected ROI position. The workaround is to always set the ROI position after setting the size. This problem has gone undetected until now since PHD2 generally only moves the ROI position (tracking the guide star), without changing the ROI size (determined by the search region setting). Callers using the new set_limit_frame server API method could see the problem when the changing the limit frame ROI.
agalasso
force-pushed
the
andy/zwo-asi-camera-roi-quirk-workaround
branch
from
a900f62 to
fa509f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZWO ASI camera: workaround quirk for ROI changing size but not changing position
When the ROI size changes without the ROI position changing, the camera returns
an invalid frame not matching the expected ROI position.
The workaround is to always set the ROI position after setting the size.
This problem has gone undetected until now since PHD2 generally only moves
the ROI position (tracking the guide star), without changing the ROI size
(determined by the search region setting).
Callers using the new set_limit_frame server API method could see the problem
when the changing the limit frame ROI.