cosmetic: cleanup config mixed case key names #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxWidgets documentation is not clear about the case-sensitivity of wxConfig key names, but key names are case-insensitive. Windows uses wxRegConfig which is always case-insensitive. Mac and Linux use wxFileConfig which has a compile time option, wxCONFIG_CASE_SENSITIVE, which defaults to 0 so those platforms are also case insensitive. For consistency and to prevent readers of the code from going off into the weeds, this PR updates a few keys to use consistent mixed case. This is purely a cosmetic change and has no effect at run time for PHD2.
bwdev01
approved these changes
Jan 31, 2026
Contributor
bwdev01
left a comment
bwdev01
left a comment
There was a problem hiding this comment.
Nice job, thanks for tracking them down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmetic: cleanup config mixed case key names
wxWidgets documentation is not clear about the case-sensitivity of
wxConfig key names, but key names are case-insensitive.
Windows uses wxRegConfig which is always case-insensitive.
Mac and Linux use wxFileConfig which has a compile time option,
wxCONFIG_CASE_SENSITIVE, which defaults to 0 so those platforms
are also case insensitive.
For consistency and to prevent readers of the code from going off into
the weeds, this PR updates a few keys to use consistent mixed case.
This is purely a cosmetic change and has no effect at run time for PHD2.