Drived Evolution Operator #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…electrical and magnetical fields
lmdiazangulo
requested changes
Jul 3, 2025
src_main_pub/evolution_operator.F90
Outdated
| @@ -0,0 +1,172 @@ | |||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | |||
Contributor
There was a problem hiding this comment.
Please remove this comments on header
…nhancement/solver_class
…handling subroutines
…ts. Adds methods to advance fields and set/get fields
…rivedEvolutionOperator
…put basis for the electrical and magnetical fields for the evolution operator
…r E indices mapping. To do: fix the correct storage in the fhash map and make an actual test
…th int_array type
…grity of the RowIndexMap and checking neighbor counts in the grid.
lmdiazangulo
requested changes
Jul 26, 2025
Contributor
There was a problem hiding this comment.
I think you should not add tests to smbjson_tests.h. That is for tests related only with the smbjson parser. Could you please move it somewhere else? Maybe you can create a new folder or add them as solver tests?
lmdiazangulo
requested changes
Jul 26, 2025
Contributor
lmdiazangulo
left a comment
lmdiazangulo
left a comment
There was a problem hiding this comment.
Ther are a lot of files showing as changes from this branch that I think have not been changed by you. Have you merged dev into DrivedEvolutionOperator recently?
…r H indices mapping
…nes for improved index mapping.
…dices mapping. Created test to begin the construction of the evolution operator and comparison with the full solver
… for JSON input handling
…on operator using the solver class
…ration functionality.
…umn index mapping and consistency checks
…ge using a sparse matrix library
…utput doesn't correspond to the theory, the evolution operator is not well defined
…ld value assignments in the EvolveState routine. Enhance tests for output field validation.
… enhance test cases. Finished first test of comparison between evolution operator and full solver. Correct typos in function names and update references to use 'semba' instead of 'json' for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.