236 investigate and separate current dependencies between observations module and the rest of the solver #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianarce-elemwave
force-pushed
the
236-investigate-and-separate-current-dependencies-between-observations-module-and-the-rest-of-the-solver
branch
from
1619bc1 to
55f9b5c
Compare
adrianarce-elemwave
force-pushed
the
236-investigate-and-separate-current-dependencies-between-observations-module-and-the-rest-of-the-solver
branch
from
55f9b5c to
219bded
Compare
adrianarce-elemwave
force-pushed
the
236-investigate-and-separate-current-dependencies-between-observations-module-and-the-rest-of-the-solver
branch
2 times, most recently
from
366393d to
e873bbf
Compare
adrianarce-elemwave
force-pushed
the
236-investigate-and-separate-current-dependencies-between-observations-module-and-the-rest-of-the-solver
branch
from
e873bbf to
2a05396
Compare
adrianarce-elemwave
force-pushed
the
236-investigate-and-separate-current-dependencies-between-observations-module-and-the-rest-of-the-solver
branch
from
2e026ff to
3fa0480
Compare
…cies-between-observations-module-and-the-rest-of-the-solver
Alberto-o
reviewed
Jan 15, 2026
Alberto-o
reviewed
Jan 15, 2026
test/utils/assertion_tools.F90
Outdated
| return | ||
| end if | ||
| do j = 1, nCols | ||
| if (abs(val(j) - expectedValues(i, j)) > 1d-6) then |
Contributor
There was a problem hiding this comment.
I think the tolerance should be user controlled with an argument, or defined as a paramenter
Contributor
There was a problem hiding this comment.
Or use the assert_real, assert_complex, etc from above, checking the kind or type of the variable
Alberto-o
reviewed
Jan 15, 2026
Alberto-o
reviewed
Jan 15, 2026
Alberto-o
reviewed
Jan 16, 2026
Contributor
There was a problem hiding this comment.
There must some problem with the yml, because ubuntu tests are failiing at the cmake point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.