-
Notifications
You must be signed in to change notification settings - Fork 3
[FIX] add pandas #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[FIX] add pandas #39
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 17. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Summary of ChangesHello @emjay0921, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a dependency requirement by integrating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the pandas library to the project's dependencies. My review focuses on ensuring the stability and reproducibility of the project's builds. I have identified one high-severity issue related to dependency management best practices.
odoo/custom/dependencies/pip.txt
Outdated
| jwcrypto | ||
| numpy>=1.22.2 | ||
| pyjwt>=2.4.0 | ||
| pandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For build stability and reproducibility, it is crucial to pin dependency versions. Adding pandas without a specific version means that any future build could pull a newer version of the library, which might contain breaking changes and cause the application to fail unexpectedly. Please specify a version to ensure consistent builds. For example: pandas==1.5.3 or pandas>=1.5.0.
|



spp_area_basenow usespandasfor importing feature. Hence the need to add pandas on pip requirements.