Add possibility to specify model run for prediction #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egordm
approved these changes
Dec 22, 2025
Collaborator
egordm
left a comment
egordm
left a comment
There was a problem hiding this comment.
Great addition. Looks good to me!
Collaborator
|
Can you run |
Signed-off-by: Ylva Björk <ylva.bjork@gmail.com>
Signed-off-by: Ylva Björk <ylva.bjork@gmail.com>
Signed-off-by: Ylva Björk <ylva.bjork@gmail.com>
ylvab
force-pushed
the
feature/add_run_name_to_mlflow_predict_callback
branch
from
7a2c071 to
bd4a91f
Compare
Contributor
Author
|
Formatting has been fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Sigholm, we use a staged deployment of new models, running them first in our staging environment before deployment to production. In order to do that, we need to control which version of a model is used. We have previously (OpenSTEF v3) used
model_idfor this, but looking at the design, the parameter run_name seems to be fit for this purpose. This change adds optimally usingrun_nameinon_predict_start, following the same pattern as inon_fit_start. Let me know if this is design aligns with the overarching ideas so that I can implement proper tests.Mainly asking @egordm, since you seem you have designed these classes.
@bartpleiter and @JanMaartenvanDoorn: FYI