Replaced deprecated setup.py with setup.cfg #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumped version to 0.7.5, with packaging being the only change. The old setup.py method is deprecated and will be removed in future python3 versions. The rationale behind this is that the setup.py script runs arbitrary code at install time. Our setup.py file used to dynamically determine the current version at install time by querying git. While this makes it more forgiving as a developer (setting a new tag is enough, no version update in any file is necessary) it's generally bad practice. I suggest setting a github action that fills this role, if possible. Otherwise we must remember to manually update the "version" attribute in the setup.cfg file when releasing a new version.
Contributor
|
@bjornwarmedal, AFAICS, this PR removes the custom build_py command, which would generate the Did you consider this removal and its (presumed - I did not test) effects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumped version to 0.7.5, with packaging being the only change.
The old setup.py method is deprecated and will be removed in future python3 versions. The rationale behind this is that the setup.py script runs arbitrary code at install time.
Our setup.py file used to dynamically determine the current version at install time by querying git. While this makes it more forgiving as a developer (setting a new tag is enough, no version update in any file is necessary) it's generally bad practice.
I suggest setting a github action that fills this role, if possible. Otherwise we must remember to manually update the "version" attribute in the setup.cfg file when releasing a new version.