Fix naming in DexTwo according to Solidity naming conventions #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
bshramin
commented
Apr 27, 2023
| contract DexTwo is Ownable { | ||
| address public token1; | ||
| address public token2; | ||
| constructor() {} |
Author
There was a problem hiding this comment.
@GianfrancoBazzani Isn't the point of this preventing the Ownable constructor from running?
Author
There was a problem hiding this comment.
I just found out that there is no way to prevent the parent contract's constructor from running in Solidity, which is weird. So, my bad.
Member
There was a problem hiding this comment.
Well, because of inheritance, the compiler includes all the parent constructors in the deploy bytecode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.